Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Issue and Pull Request templates #86

Merged
merged 8 commits into from
Nov 7, 2024
Merged

Adding Issue and Pull Request templates #86

merged 8 commits into from
Nov 7, 2024

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Oct 24, 2024

Adding Issue and Pull Request templates mirroring the main OTTR template.

Specifically was doing this because we added issue and pr templates for adding courses to OTTR syncs and we wanted to do this for websites too.

Used wget to get the raw .md files for each issue and PR template and edited them to reflect websites instead of courses.

Still need to add a new website cleanup workflow because several of the templates assign @cansavvy to handle the issue or PR and we don't want that happening in other people's websites. @cansavvy do you want me to try to do this in a stacked PR and have you review it?

Copy link

github-actions bot commented Oct 24, 2024

No spelling errors! 🎉
Comment updated at 2024-11-07-00:37:03 with changes from d5ef425

Copy link

github-actions bot commented Oct 24, 2024

No broken url errors! 🎉
Comment updated at 2024-11-07-00:37:00 with changes from d5ef425

Copy link

github-actions bot commented Oct 24, 2024

👀 Quick preview of website here *
🔬 Comprehensive download of the website here

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-11-07 with changes from the latest commit d5ef425

@kweav kweav requested a review from cansavvy October 25, 2024 18:56
@kweav
Copy link
Contributor Author

kweav commented Nov 7, 2024

@cansavvy added steps to the filing automatic issues workflow yml since it overlaps the starting-course workflow from the main OTTR template. This should be ready for your review

@kweav
Copy link
Contributor Author

kweav commented Nov 7, 2024

Related main OTTR template PR this one is emulating: jhudsl/OTTR_Template#759

Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @kweav !!

I do wonder if this many issue templates will be a little overwhelming for users but I lean toward thinking its probably less overwhelming than a blank issue page so probably better. Let's try it out and we can always change it later.

@cansavvy
Copy link
Contributor

cansavvy commented Nov 7, 2024

@cansavvy do you want me to try to do this in a stacked PR and have you review it?

We can merge this and then no need for stacked you can start a new PR. Thanks again!

@kweav
Copy link
Contributor Author

kweav commented Nov 7, 2024

@cansavvy do you want me to try to do this in a stacked PR and have you review it?

We can merge this and then no need for stacked you can start a new PR. Thanks again!

Oh sorry, I didn't update the description. This commit was the work that I was going to do next in a stacked PR if I didn't get to it before your review: 79abeb8

@kweav kweav merged commit 7edbdb0 into main Nov 7, 2024
6 checks passed
@kweav kweav deleted the issueTemplate branch November 7, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants