JENKINS-73941 - Option to hide "Use Groovy Sandbox" for users without Administer permission globally in the system #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Administer permission globally in the system
6 tasks
car-roll
reviewed
Oct 24, 2024
Co-authored-by: Carroll Chiou <[email protected]>
|
Closing and reopening to run again the checks as there are some flaky failures |
amuniz
reviewed
Oct 24, 2024
plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/config/CPSConfiguration.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/config/CPSConfiguration.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/config/CPSConfiguration.java
Outdated
Show resolved
Hide resolved
plugin/src/test/resources/org/jenkinsci/plugins/workflow/cps/casc_test.yaml
Show resolved
Hide resolved
Co-authored-by: Antonio Muniz <[email protected]>
…ugin incremental version
…ugin incremental version
jglick
reviewed
Oct 24, 2024
...n/src/main/resources/org/jenkinsci/plugins/workflow/cps/config/CPSConfiguration/config.jelly
Show resolved
Hide resolved
jglick
reviewed
Oct 24, 2024
plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/config/CPSConfiguration.java
Outdated
Show resolved
Hide resolved
jglick
reviewed
Oct 24, 2024
#948 (comment) There is no JCasC test here that I can see. |
jglick
reviewed
Oct 24, 2024
plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/config/CPSConfiguration.java
Show resolved
Hide resolved
|
Hi @jglick, we have implemented the CASC compatibility, so the breaking change does not apply after the latest commit. |
jglick
reviewed
Oct 25, 2024
Co-authored-by: Jesse Glick <[email protected]>
amuniz
reviewed
Oct 29, 2024
plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/config/CPSConfiguration.java
Show resolved
Hide resolved
6 tasks
jglick
reviewed
Oct 29, 2024
| public void cascExport() throws Exception { | ||
| ConfiguratorRegistry registry = ConfiguratorRegistry.get(); | ||
| ConfigurationContext context = new ConfigurationContext(registry); | ||
| CNode yourAttribute = getSecurityRoot(context).get("cps"); |
There was a problem hiding this comment.
I think more interesting would be to check what is then exported from the script-security version.
jglick
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-73941
This is partially implemented in JENKINS-73470, where we created the new option "Hide Sandbox checkbox in pipeline jobs", but it was created in the scope of this plugin.
The scope of this ticket is just to create the global option at the "script-security-plugin", to be used by all plugins depending on the sandbox.
Script Security Plugin PR including this change:
jenkinsci/script-security-plugin#584
Testing done
Created new test method covering the changes + CASC.
Submitter checklist