Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JENKINS-73941 - ForceSandbox - Unify logic in Script-Security for reducing techDeb #952

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

jgarciacloudbees
Copy link
Contributor

@jgarciacloudbees jgarciacloudbees commented Oct 31, 2024

JENKINS-73941 - Option to hide "Use Groovy Sandbox" for users without Administer permission globally in the system

Complements #948

In jenkinsci/script-security-plugin#586, some additional shared methods have been included to better manage the shared logics related to the ForceSandbox functionality. We are including such methods to the current plugin logic.

This PR does not include any new functionality, but decrease the techDebt maintaining both, Script-Security and Workflow-CPS Plugin.

Testing done

No new tests are required.
Tests implemented in #948 are already covering the new Scipt-Security logic.

The tests for the specific Script Security new functionality is already implemented in jenkinsci/script-security-plugin#586

We have executed some manual tests related to the Sandbox checkbox, and the behavior is the same than before the change

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • NOT APPLY - Ensure you have provided tests - that demonstrates feature works or fixes the issue --> Please see Testing comments.

@jglick jglick added the chore label Oct 31, 2024
…plugin - Incremental Script-Security version
plugin/pom.xml Outdated Show resolved Hide resolved
@jglick jglick marked this pull request as ready for review November 13, 2024 21:02
@jglick jglick requested a review from a team as a code owner November 13, 2024 21:02
@jglick jglick enabled auto-merge (squash) November 13, 2024 21:03
@jglick jglick merged commit 5eebd32 into jenkinsci:master Nov 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants