JENKINS-73941 - ForceSandbox - Unify logic in Script-Security for reducing techDeb #952
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JENKINS-73941 - Option to hide "Use Groovy Sandbox" for users without Administer permission globally in the system
Complements #948
In jenkinsci/script-security-plugin#586, some additional shared methods have been included to better manage the shared logics related to the ForceSandbox functionality. We are including such methods to the current plugin logic.
This PR does not include any new functionality, but decrease the techDebt maintaining both, Script-Security and Workflow-CPS Plugin.
Testing done
No new tests are required.
Tests implemented in #948 are already covering the new Scipt-Security logic.
The tests for the specific Script Security new functionality is already implemented in jenkinsci/script-security-plugin#586
We have executed some manual tests related to the Sandbox checkbox, and the behavior is the same than before the change
Submitter checklist