Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform beta release #298

Merged
merged 10 commits into from
May 21, 2024
Merged

Platform beta release #298

merged 10 commits into from
May 21, 2024

Conversation

drizzentic
Copy link
Collaborator

@drizzentic drizzentic commented May 15, 2024

Summary by CodeRabbit

  • New Features

    • Added fhir-ig-importer and reprocess-mediator profiles for enhanced functionality.
    • Introduced new network configurations for various services to improve connectivity and organization.
  • Bug Fixes

    • Updated port mappings and URLs for fhir-ig-importer and reprocess-mediator services to resolve conflicts and improve access.
  • Improvements

    • Updated versioning for multiple services to ensure compatibility and leverage new features.
    • Enhanced transformation logic in JSON configurations for better data handling.
    • Streamlined Docker Compose files for better network management and service isolation.
  • Chores

    • Updated base image versions in Dockerfiles for consistency and security updates.

@rcrichton
Copy link
Member

Task linked: CU-86bxx8wt8 Platform release beta

@drizzentic drizzentic requested a review from bradsawadye May 15, 2024 14:34
Copy link
Contributor

coderabbitai bot commented May 15, 2024

Walkthrough

This update introduces significant enhancements across various components, including adding new networks and services, updating version numbers, and modifying port configurations. Key changes involve integrating new profiles, updating Docker Compose files for multiple services, and refining JSON configurations. These modifications aim to improve network configurations, version management, and overall system interoperability.

Changes

File(s) Change Summary
config.yaml Added fhir-ig-importer and reprocess-mediator to the profiles list.
fhir-ig-importer/docker-compose.dev.yml, reprocess-mediator/docker-compose.dev.yml Updated port mappings for services.
fhir-ig-importer/importer/volume/ig-importer-app.json Updated URL configuration for the microfrontend app.
fhir-ig-importer/package-metadata.json, interoperability-layer-openhim/package-metadata.json, kafka-mapper-consumer/package-metadata.json, reprocess-mediator/package-metadata.json, mpi-mediator/package-metadata.json Updated version numbers for various services.
fhir-ig-importer/docker-compose.yml, fhir-ig-importer/importer/docker-compose.config.yml, kafka-mapper-consumer/docker-compose.config.yml, kafka-mapper-consumer/docker-compose.yml Added new network configurations.
mpi-mediator/docker-compose.yml Updated to use a dynamic version for the jembi/mpi-mediator image.
mpi-mediator/importer/volume/openhim-import.json Simplified array syntax, adjusted priority values, and streamlined role assignments.
client-registry-jempi/importer/mapping-mediator/searchAll.json Modified transformation in the inputTransforms section.
test/cucumber/features/steps/recipesSteps.js Added new constants and functions for Kafka-related services.
test/cucumber/features/single-mode/kafka-packages.feature Updated parameters for initializing and destroying Kafka-related services.
Dockerfile Updated base image version.
client-registry-jempi/.../docker-compose.*.yml Added new service and network configurations across multiple Docker Compose files.
client-registry-jempi/swarm.sh Enabled specific configurations for clustered mode.

In code's embrace, new networks bloom,
Ports shift and services find their room.
Versions rise, configs refine,
A dance of bytes in perfect line.
With every change, we weave a tale,
Of systems strong, that never fail.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@drizzentic drizzentic force-pushed the CU-86bxx8wt8_Platform-release-beta branch 2 times, most recently from 4c8a089 to 9a7dbe4 Compare May 15, 2024 15:38
@drizzentic drizzentic marked this pull request as ready for review May 15, 2024 15:39
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 67e1a49 and 9a7dbe4.
Files selected for processing (10)
  • config.yaml (2 hunks)
  • fhir-ig-importer/docker-compose.dev.yml (1 hunks)
  • fhir-ig-importer/importer/volume/ig-importer-app.json (1 hunks)
  • fhir-ig-importer/package-metadata.json (1 hunks)
  • interoperability-layer-openhim/package-metadata.json (1 hunks)
  • kafka-mapper-consumer/package-metadata.json (1 hunks)
  • mpi-mediator/docker-compose.yml (1 hunks)
  • mpi-mediator/importer/volume/openhim-import.json (6 hunks)
  • reprocess-mediator/package-metadata.json (1 hunks)
  • test/cucumber/features/steps/recipesSteps.js (3 hunks)
Files skipped from review due to trivial changes (7)
  • fhir-ig-importer/docker-compose.dev.yml
  • fhir-ig-importer/importer/volume/ig-importer-app.json
  • fhir-ig-importer/package-metadata.json
  • interoperability-layer-openhim/package-metadata.json
  • kafka-mapper-consumer/package-metadata.json
  • mpi-mediator/docker-compose.yml
  • reprocess-mediator/package-metadata.json
Additional comments not posted (7)
config.yaml (1)

47-48: Ensure that the fhir-ig-importer and reprocess-mediator profiles are correctly integrated and that all necessary configurations and dependencies are in place.

test/cucumber/features/steps/recipesSteps.js (2)

5-7: The new imports for path and ClickHouse are appropriate and necessary for the added functionality.


11-12: The new constants for HOST, CLICKHOUSE_PORT, and CLICKHOUSE_DEBUG are well-defined and follow best practices for environment variable usage.

mpi-mediator/importer/volume/openhim-import.json (4)

8-8: The update to include "admin" in the user groups is appropriate for the user configuration.


22-22: The update to include "instant" in the client roles is appropriate for the client configuration.


97-97: Ensure that the updated priority values and allowed roles are correctly integrated and do not conflict with other configurations.

Also applies to: 154-154, 235-235


323-323: The update to include "instant" in the allowed roles for the mediator configuration is appropriate.

test/cucumber/features/steps/recipesSteps.js Show resolved Hide resolved
test/cucumber/features/steps/recipesSteps.js Show resolved Hide resolved
@drizzentic drizzentic closed this May 15, 2024
@drizzentic drizzentic deleted the CU-86bxx8wt8_Platform-release-beta branch May 15, 2024 15:54
@drizzentic drizzentic restored the CU-86bxx8wt8_Platform-release-beta branch May 15, 2024 15:54
@drizzentic drizzentic deleted the CU-86bxx8wt8_Platform-release-beta branch May 15, 2024 16:06
@drizzentic drizzentic restored the CU-86bxx8wt8_Platform-release-beta branch May 15, 2024 16:07
@drizzentic drizzentic reopened this May 15, 2024
@drizzentic drizzentic marked this pull request as draft May 15, 2024 16:12
@drizzentic drizzentic marked this pull request as ready for review May 15, 2024 16:13
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 9a7dbe4 and 39c73c9.
Files selected for processing (1)
  • test/cucumber/features/steps/recipesSteps.js (3 hunks)
Files skipped from review as they are similar to previous changes (1)
  • test/cucumber/features/steps/recipesSteps.js

@drizzentic drizzentic marked this pull request as draft May 15, 2024 16:15
@drizzentic drizzentic marked this pull request as ready for review May 15, 2024 16:15
@drizzentic drizzentic marked this pull request as draft May 15, 2024 16:16
@drizzentic drizzentic marked this pull request as ready for review May 15, 2024 16:21
@drizzentic drizzentic force-pushed the CU-86bxx8wt8_Platform-release-beta branch from 39c73c9 to e0d2d5a Compare May 15, 2024 18:21
@drizzentic drizzentic marked this pull request as draft May 15, 2024 18:21
@drizzentic drizzentic marked this pull request as ready for review May 15, 2024 18:21
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 39c73c9 and e0d2d5a.
Files selected for processing (11)
  • config.yaml (2 hunks)
  • fhir-ig-importer/docker-compose.dev.yml (1 hunks)
  • fhir-ig-importer/importer/volume/ig-importer-app.json (1 hunks)
  • fhir-ig-importer/package-metadata.json (1 hunks)
  • interoperability-layer-openhim/package-metadata.json (1 hunks)
  • kafka-mapper-consumer/package-metadata.json (1 hunks)
  • mpi-mediator/docker-compose.yml (1 hunks)
  • mpi-mediator/importer/volume/openhim-import.json (6 hunks)
  • reprocess-mediator/docker-compose.dev.yml (1 hunks)
  • reprocess-mediator/package-metadata.json (1 hunks)
  • test/cucumber/features/steps/recipesSteps.js (3 hunks)
Files skipped from review due to trivial changes (1)
  • reprocess-mediator/docker-compose.dev.yml
Files skipped from review as they are similar to previous changes (10)
  • config.yaml
  • fhir-ig-importer/docker-compose.dev.yml
  • fhir-ig-importer/importer/volume/ig-importer-app.json
  • fhir-ig-importer/package-metadata.json
  • interoperability-layer-openhim/package-metadata.json
  • kafka-mapper-consumer/package-metadata.json
  • mpi-mediator/docker-compose.yml
  • mpi-mediator/importer/volume/openhim-import.json
  • reprocess-mediator/package-metadata.json
  • test/cucumber/features/steps/recipesSteps.js

@drizzentic drizzentic marked this pull request as draft May 16, 2024 03:34
@drizzentic drizzentic marked this pull request as ready for review May 16, 2024 03:34
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between e0d2d5a and 4da745e.
Files selected for processing (4)
  • fhir-ig-importer/docker-compose.yml (2 hunks)
  • fhir-ig-importer/importer/docker-compose.config.yml (1 hunks)
  • kafka-mapper-consumer/docker-compose.config.yml (1 hunks)
  • kafka-mapper-consumer/docker-compose.yml (2 hunks)
Files skipped from review due to trivial changes (4)
  • fhir-ig-importer/docker-compose.yml
  • fhir-ig-importer/importer/docker-compose.config.yml
  • kafka-mapper-consumer/docker-compose.config.yml
  • kafka-mapper-consumer/docker-compose.yml

@drizzentic drizzentic marked this pull request as draft May 16, 2024 07:57
@drizzentic drizzentic marked this pull request as ready for review May 16, 2024 07:57
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between a9687fd and 29ec530.
Files selected for processing (1)
  • test/cucumber/features/single-mode/kafka-packages.feature (3 hunks)
Additional comments not posted (2)
test/cucumber/features/single-mode/kafka-packages.feature (2)

21-25: Ensure the networks clickhouse_public, kafka_public, and openhim_public are correctly configured and exist in the environment.

Verification successful

The networks clickhouse_public, kafka_public, and openhim_public are correctly configured and exist in the environment, as evidenced by their definitions in multiple docker-compose.yml files and references in feature files.

  • clickhouse_public found in:

    • mpi-mediator/docker-compose.yml
    • kafka-mapper-consumer/docker-compose.yml
    • dashboard-visualiser-superset/docker-compose.yml
    • analytics-datastore-clickhouse/docker-compose.yml
    • analytics-datastore-clickhouse/docker-compose.cluster.yml
  • kafka_public found in:

    • openhim-mapping-mediator/docker-compose.yml
    • message-bus-kafka/docker-compose.kafka-utils.yml
    • message-bus-helper-hapi-proxy/docker-compose.yml
    • message-bus-kafka/docker-compose.kafka.yml
    • kafka-unbundler-consumer/docker-compose.yml
    • kafka-mapper-consumer/docker-compose.yml
    • interoperability-layer-openhim/docker-compose.yml
    • data-mapper-logstash/docker-compose.yml
    • client-registry-jempi/importer/docker-compose.config.yml
    • client-registry-jempi/docker-compose.combined.yml
    • client-registry-jempi/docker-compose.api.yml
  • openhim_public found in:

    • reprocess-mediator/docker-compose.yml
    • openhim-mapping-mediator/docker-compose.yml
    • mpi-mediator/docker-compose.yml
    • mpi-mediator/importer/docker-compose.config.yml
    • message-bus-helper-hapi-proxy/docker-compose.yml
    • kafka-mapper-consumer/docker-compose.yml
    • kafka-mapper-consumer/docker-compose.config.yml
    • interoperability-layer-openhim/docker-compose.yml
    • fhir-ig-importer/docker-compose.yml
    • fhir-ig-importer/importer/docker-compose.config.yml
    • client-registry-jempi/importer/openhim/docker-compose.config.yml
Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the existence and configuration of the specified networks.

# Test: List Docker networks and check for the specified networks.
docker network ls | grep -E 'clickhouse_public|kafka_public|openhim_public'

Length of output: 151



Script:

#!/bin/bash
# Description: Search for the network names in the codebase to verify their existence and configuration.

# Search for 'clickhouse_public' network definition
rg 'clickhouse_public'

# Search for 'kafka_public' network definition
rg 'kafka_public'

# Search for 'openhim_public' network definition
rg 'openhim_public'

Length of output: 9140


Line range hint 35-46: Ensure the networks kafka_public, clickhouse_public, prometheus_public, and openhim_public are correctly configured and exist in the environment.

Verification successful

Networks kafka_public, clickhouse_public, prometheus_public, and openhim_public are configured in the codebase

The search results confirm that the networks kafka_public, clickhouse_public, prometheus_public, and openhim_public are indeed configured in various docker-compose files and feature files within the codebase.

  • kafka_public is found in multiple docker-compose files and feature files.
  • clickhouse_public is found in docker-compose files and feature files.
  • prometheus_public is found in docker-compose files and feature files.
  • openhim_public is found in docker-compose files and feature files.

These configurations indicate that the networks are set up and referenced correctly in the environment.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the existence and configuration of the specified networks.

# Test: List Docker networks and check for the specified networks.
docker network ls | grep -E 'kafka_public|clickhouse_public|prometheus_public|openhim_public'

Length of output: 169



Script:

#!/bin/bash
# Description: Search for the specified network names in the codebase to verify their configuration.

# Search for network names in the codebase
rg 'kafka_public|clickhouse_public|prometheus_public|openhim_public'

Length of output: 9064

@rcrichton
Copy link
Member

rcrichton commented May 16, 2024

@drizzentic this was from a previous change but I think we should leave the config file pointing to jembi/platform:latest, instead of:

https://github.com/jembi/platform/pull/298/files#diff-d8d0422389f03d783e32e627250fe29834bd09c6361640d1ff00661dd6820034L2

As this file will get changed by the CI action and uploaded as part of the release, see:

sed -i "s/latest/${{ github.event.release.tag_name }}/g" config.yaml

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 29ec530 and fa9ad5b.
Files selected for processing (1)
  • Dockerfile (1 hunks)
Files skipped from review due to trivial changes (1)
  • Dockerfile

This also adds bootstrapper node placement. Has to be on the leader where the commands are run as we run a command in the bootstrapper docker container
…/platform into CU-86bxx8wt8_Platform-release-beta
@bradsawadye bradsawadye marked this pull request as draft May 17, 2024 09:47
@bradsawadye bradsawadye marked this pull request as ready for review May 17, 2024 09:48
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between fa9ad5b and 5be40a2.
Files selected for processing (7)
  • client-registry-jempi/docker-compose.api.yml (3 hunks)
  • client-registry-jempi/docker-compose.combined-cluster.yml (3 hunks)
  • client-registry-jempi/docker-compose.combined.yml (7 hunks)
  • client-registry-jempi/docker-compose.dgraph-zero-cluster.yml (3 hunks)
  • client-registry-jempi/docker-compose.dgraph-zero.yml (1 hunks)
  • client-registry-jempi/docker-compose.dgraph.yml (4 hunks)
  • client-registry-jempi/swarm.sh (1 hunks)
Additional comments not posted (7)
client-registry-jempi/docker-compose.dgraph-zero.yml (1)

18-19: Network configuration for jempi added correctly.

Also applies to: 24-27

client-registry-jempi/docker-compose.dgraph-zero-cluster.yml (1)

10-12: Network configuration for jempi added correctly across all Dgraph Zero cluster nodes.

Also applies to: 30-31, 50-51, 58-60

client-registry-jempi/docker-compose.dgraph.yml (1)

19-20: Network configuration for jempi added correctly across all Dgraph Alpha instances and the Ratel UI.

Also applies to: 37-38, 55-56, 70-71, 79-81

client-registry-jempi/docker-compose.combined-cluster.yml (1)

45-46: Network configuration for jempi added correctly across all PostgreSQL instances and the bootstrapper.

Also applies to: 77-78, 85-87

client-registry-jempi/docker-compose.api.yml (1)

36-36: Network configuration for jempi added correctly across both API and API-KC instances.

Also applies to: 81-81, 92-94

client-registry-jempi/swarm.sh (1)

55-59: Handling of clustered mode added correctly to the script.

client-registry-jempi/docker-compose.combined.yml (1)

22-22: Network configuration for jempi added correctly across all services in the combined configuration.

Also applies to: 41-41, 75-75, 110-110, 131-131, 160-160, 172-174

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 5be40a2 and 1cac0f7.
Files selected for processing (2)
  • config.yaml (3 hunks)
  • interoperability-layer-openhim/docker-compose.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • interoperability-layer-openhim/docker-compose.yml
Files skipped from review as they are similar to previous changes (1)
  • config.yaml

@drizzentic drizzentic marked this pull request as draft May 20, 2024 06:32
@drizzentic drizzentic marked this pull request as ready for review May 20, 2024 06:32
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 1cac0f7 and 370bd14.
Files selected for processing (2)
  • mpi-mediator/docker-compose.yml (1 hunks)
  • mpi-mediator/package-metadata.json (1 hunks)
Files skipped from review due to trivial changes (1)
  • mpi-mediator/package-metadata.json
Files skipped from review as they are similar to previous changes (1)
  • mpi-mediator/docker-compose.yml

Copy link
Contributor

@brett-onions brett-onions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants