-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Platform beta release #298
Conversation
Task linked: CU-86bxx8wt8 Platform release beta |
WalkthroughThis update introduces significant enhancements across various components, including adding new networks and services, updating version numbers, and modifying port configurations. Key changes involve integrating new profiles, updating Docker Compose files for multiple services, and refining JSON configurations. These modifications aim to improve network configurations, version management, and overall system interoperability. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
4c8a089
to
9a7dbe4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- config.yaml (2 hunks)
- fhir-ig-importer/docker-compose.dev.yml (1 hunks)
- fhir-ig-importer/importer/volume/ig-importer-app.json (1 hunks)
- fhir-ig-importer/package-metadata.json (1 hunks)
- interoperability-layer-openhim/package-metadata.json (1 hunks)
- kafka-mapper-consumer/package-metadata.json (1 hunks)
- mpi-mediator/docker-compose.yml (1 hunks)
- mpi-mediator/importer/volume/openhim-import.json (6 hunks)
- reprocess-mediator/package-metadata.json (1 hunks)
- test/cucumber/features/steps/recipesSteps.js (3 hunks)
Files skipped from review due to trivial changes (7)
- fhir-ig-importer/docker-compose.dev.yml
- fhir-ig-importer/importer/volume/ig-importer-app.json
- fhir-ig-importer/package-metadata.json
- interoperability-layer-openhim/package-metadata.json
- kafka-mapper-consumer/package-metadata.json
- mpi-mediator/docker-compose.yml
- reprocess-mediator/package-metadata.json
Additional comments not posted (7)
config.yaml (1)
47-48
: Ensure that thefhir-ig-importer
andreprocess-mediator
profiles are correctly integrated and that all necessary configurations and dependencies are in place.test/cucumber/features/steps/recipesSteps.js (2)
5-7
: The new imports forpath
andClickHouse
are appropriate and necessary for the added functionality.
11-12
: The new constants forHOST
,CLICKHOUSE_PORT
, andCLICKHOUSE_DEBUG
are well-defined and follow best practices for environment variable usage.mpi-mediator/importer/volume/openhim-import.json (4)
8-8
: The update to include "admin" in the user groups is appropriate for the user configuration.
22-22
: The update to include "instant" in the client roles is appropriate for the client configuration.
97-97
: Ensure that the updated priority values and allowed roles are correctly integrated and do not conflict with other configurations.Also applies to: 154-154, 235-235
323-323
: The update to include "instant" in the allowed roles for the mediator configuration is appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- test/cucumber/features/steps/recipesSteps.js (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- test/cucumber/features/steps/recipesSteps.js
39c73c9
to
e0d2d5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (11)
- config.yaml (2 hunks)
- fhir-ig-importer/docker-compose.dev.yml (1 hunks)
- fhir-ig-importer/importer/volume/ig-importer-app.json (1 hunks)
- fhir-ig-importer/package-metadata.json (1 hunks)
- interoperability-layer-openhim/package-metadata.json (1 hunks)
- kafka-mapper-consumer/package-metadata.json (1 hunks)
- mpi-mediator/docker-compose.yml (1 hunks)
- mpi-mediator/importer/volume/openhim-import.json (6 hunks)
- reprocess-mediator/docker-compose.dev.yml (1 hunks)
- reprocess-mediator/package-metadata.json (1 hunks)
- test/cucumber/features/steps/recipesSteps.js (3 hunks)
Files skipped from review due to trivial changes (1)
- reprocess-mediator/docker-compose.dev.yml
Files skipped from review as they are similar to previous changes (10)
- config.yaml
- fhir-ig-importer/docker-compose.dev.yml
- fhir-ig-importer/importer/volume/ig-importer-app.json
- fhir-ig-importer/package-metadata.json
- interoperability-layer-openhim/package-metadata.json
- kafka-mapper-consumer/package-metadata.json
- mpi-mediator/docker-compose.yml
- mpi-mediator/importer/volume/openhim-import.json
- reprocess-mediator/package-metadata.json
- test/cucumber/features/steps/recipesSteps.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- fhir-ig-importer/docker-compose.yml (2 hunks)
- fhir-ig-importer/importer/docker-compose.config.yml (1 hunks)
- kafka-mapper-consumer/docker-compose.config.yml (1 hunks)
- kafka-mapper-consumer/docker-compose.yml (2 hunks)
Files skipped from review due to trivial changes (4)
- fhir-ig-importer/docker-compose.yml
- fhir-ig-importer/importer/docker-compose.config.yml
- kafka-mapper-consumer/docker-compose.config.yml
- kafka-mapper-consumer/docker-compose.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- test/cucumber/features/single-mode/kafka-packages.feature (3 hunks)
Additional comments not posted (2)
test/cucumber/features/single-mode/kafka-packages.feature (2)
21-25
: Ensure the networksclickhouse_public
,kafka_public
, andopenhim_public
are correctly configured and exist in the environment.Verification successful
The networks
clickhouse_public
,kafka_public
, andopenhim_public
are correctly configured and exist in the environment, as evidenced by their definitions in multipledocker-compose.yml
files and references in feature files.
clickhouse_public
found in:
mpi-mediator/docker-compose.yml
kafka-mapper-consumer/docker-compose.yml
dashboard-visualiser-superset/docker-compose.yml
analytics-datastore-clickhouse/docker-compose.yml
analytics-datastore-clickhouse/docker-compose.cluster.yml
kafka_public
found in:
openhim-mapping-mediator/docker-compose.yml
message-bus-kafka/docker-compose.kafka-utils.yml
message-bus-helper-hapi-proxy/docker-compose.yml
message-bus-kafka/docker-compose.kafka.yml
kafka-unbundler-consumer/docker-compose.yml
kafka-mapper-consumer/docker-compose.yml
interoperability-layer-openhim/docker-compose.yml
data-mapper-logstash/docker-compose.yml
client-registry-jempi/importer/docker-compose.config.yml
client-registry-jempi/docker-compose.combined.yml
client-registry-jempi/docker-compose.api.yml
openhim_public
found in:
reprocess-mediator/docker-compose.yml
openhim-mapping-mediator/docker-compose.yml
mpi-mediator/docker-compose.yml
mpi-mediator/importer/docker-compose.config.yml
message-bus-helper-hapi-proxy/docker-compose.yml
kafka-mapper-consumer/docker-compose.yml
kafka-mapper-consumer/docker-compose.config.yml
interoperability-layer-openhim/docker-compose.yml
fhir-ig-importer/docker-compose.yml
fhir-ig-importer/importer/docker-compose.config.yml
client-registry-jempi/importer/openhim/docker-compose.config.yml
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence and configuration of the specified networks. # Test: List Docker networks and check for the specified networks. docker network ls | grep -E 'clickhouse_public|kafka_public|openhim_public'Length of output: 151
Script:
#!/bin/bash # Description: Search for the network names in the codebase to verify their existence and configuration. # Search for 'clickhouse_public' network definition rg 'clickhouse_public' # Search for 'kafka_public' network definition rg 'kafka_public' # Search for 'openhim_public' network definition rg 'openhim_public'Length of output: 9140
Line range hint
35-46
: Ensure the networkskafka_public
,clickhouse_public
,prometheus_public
, andopenhim_public
are correctly configured and exist in the environment.Verification successful
Networks
kafka_public
,clickhouse_public
,prometheus_public
, andopenhim_public
are configured in the codebaseThe search results confirm that the networks
kafka_public
,clickhouse_public
,prometheus_public
, andopenhim_public
are indeed configured in variousdocker-compose
files and feature files within the codebase.
kafka_public
is found in multipledocker-compose
files and feature files.clickhouse_public
is found indocker-compose
files and feature files.prometheus_public
is found indocker-compose
files and feature files.openhim_public
is found indocker-compose
files and feature files.These configurations indicate that the networks are set up and referenced correctly in the environment.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence and configuration of the specified networks. # Test: List Docker networks and check for the specified networks. docker network ls | grep -E 'kafka_public|clickhouse_public|prometheus_public|openhim_public'Length of output: 169
Script:
#!/bin/bash # Description: Search for the specified network names in the codebase to verify their configuration. # Search for network names in the codebase rg 'kafka_public|clickhouse_public|prometheus_public|openhim_public'Length of output: 9064
@drizzentic this was from a previous change but I think we should leave the config file pointing to jembi/platform:latest, instead of: As this file will get changed by the CI action and uploaded as part of the release, see: platform/.github/workflows/main.yaml Line 17 in d6efe12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
This also adds bootstrapper node placement. Has to be on the leader where the commands are run as we run a command in the bootstrapper docker container
…/platform into CU-86bxx8wt8_Platform-release-beta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- client-registry-jempi/docker-compose.api.yml (3 hunks)
- client-registry-jempi/docker-compose.combined-cluster.yml (3 hunks)
- client-registry-jempi/docker-compose.combined.yml (7 hunks)
- client-registry-jempi/docker-compose.dgraph-zero-cluster.yml (3 hunks)
- client-registry-jempi/docker-compose.dgraph-zero.yml (1 hunks)
- client-registry-jempi/docker-compose.dgraph.yml (4 hunks)
- client-registry-jempi/swarm.sh (1 hunks)
Additional comments not posted (7)
client-registry-jempi/docker-compose.dgraph-zero.yml (1)
18-19
: Network configuration forjempi
added correctly.Also applies to: 24-27
client-registry-jempi/docker-compose.dgraph-zero-cluster.yml (1)
10-12
: Network configuration forjempi
added correctly across all Dgraph Zero cluster nodes.Also applies to: 30-31, 50-51, 58-60
client-registry-jempi/docker-compose.dgraph.yml (1)
19-20
: Network configuration forjempi
added correctly across all Dgraph Alpha instances and the Ratel UI.Also applies to: 37-38, 55-56, 70-71, 79-81
client-registry-jempi/docker-compose.combined-cluster.yml (1)
45-46
: Network configuration forjempi
added correctly across all PostgreSQL instances and the bootstrapper.Also applies to: 77-78, 85-87
client-registry-jempi/docker-compose.api.yml (1)
36-36
: Network configuration forjempi
added correctly across both API and API-KC instances.Also applies to: 81-81, 92-94
client-registry-jempi/swarm.sh (1)
55-59
: Handling of clustered mode added correctly to the script.client-registry-jempi/docker-compose.combined.yml (1)
22-22
: Network configuration forjempi
added correctly across all services in the combined configuration.Also applies to: 41-41, 75-75, 110-110, 131-131, 160-160, 172-174
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- config.yaml (3 hunks)
- interoperability-layer-openhim/docker-compose.yml (1 hunks)
Files skipped from review due to trivial changes (1)
- interoperability-layer-openhim/docker-compose.yml
Files skipped from review as they are similar to previous changes (1)
- config.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- mpi-mediator/docker-compose.yml (1 hunks)
- mpi-mediator/package-metadata.json (1 hunks)
Files skipped from review due to trivial changes (1)
- mpi-mediator/package-metadata.json
Files skipped from review as they are similar to previous changes (1)
- mpi-mediator/docker-compose.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Summary by CodeRabbit
New Features
fhir-ig-importer
andreprocess-mediator
profiles for enhanced functionality.Bug Fixes
fhir-ig-importer
andreprocess-mediator
services to resolve conflicts and improve access.Improvements
Chores