Improve AV1 support - Fix direct streaming with no sound #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimdogx
approved these changes
Nov 13, 2024
cewert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct streaming AV1 results in no audio. Changing the container to .ts or .mkv results in no video. This removes av1 from the transcoding profile so that if the audio codec gets changed the video codec gets changed as well.
Roku doesn't seem to support HLS fMP4 https://community.roku.com/t5/Roku-Developer-Program/HLS-fMP4-No-Audio/td-p/607399 which I also confirmed using the stream tester. The audio stream is undetected. I swear the files I used to test #2001 had audio but they definitely don't have audio now 🤷
If you want your AV1 files to always direct play, you will need a stereo audio stream until Roku fixes this.
Changes
Issues
Ref #1851