Skip to content

Commit

Permalink
Merge pull request #2044 from cewert/fix-av1-no-sound
Browse files Browse the repository at this point in the history
  • Loading branch information
cewert authored Nov 13, 2024
2 parents 6d87f3a + a79c259 commit d3cf38a
Showing 1 changed file with 3 additions and 18 deletions.
21 changes: 3 additions & 18 deletions source/utils/deviceCapabilities.bs
Original file line number Diff line number Diff line change
Expand Up @@ -211,19 +211,6 @@ function getTranscodingProfiles() as object
'
' AVC / h264 / MPEG4 AVC
for each container in transcodingContainers
if di.CanDecodeVideo({ Codec: "h264", Container: container }).Result
if container = "mp4"
' check for codec string before adding it
if mp4VideoCodecs.Instr(0, ",h264") = -1
mp4VideoCodecs = mp4VideoCodecs + ",h264"
end if
else if container = "ts"
' check for codec string before adding it
if tsVideoCodecs.Instr(0, ",h264") = -1
tsVideoCodecs = tsVideoCodecs + ",h264"
end if
end if
end if
if di.CanDecodeVideo({ Codec: "mpeg4 avc", Container: container }).Result
if container = "mp4"
' check for codec string before adding it
Expand Down Expand Up @@ -301,11 +288,9 @@ function getTranscodingProfiles() as object
end if

' AV1
' CanDecodeVideo() returns false for AV1 when the container is provided
' Manually add AV1 to the mp4VideoCodecs list if support is detected
if di.CanDecodeVideo({ Codec: "av1" }).Result
mp4VideoCodecs = mp4VideoCodecs + ",av1"
end if
' direct streaming av1 is not supported on roku
' force a full transcode by omitting av1 from the transcoding profile
' https://community.roku.com/t5/Roku-Developer-Program/HLS-fMP4-No-Audio/td-p/607399

' AUDIO CODECS
for each container in transcodingContainers
Expand Down

0 comments on commit d3cf38a

Please sign in to comment.