Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quickplay support to search results #1456

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Add quickplay support to search results #1456

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8c0fc20
add quickplay support to search results
cewert Oct 29, 2023
187a052
precent focusing on the search results until there is data
cewert Oct 29, 2023
a942cb5
use TotalRecordCount to check search results state
cewert Oct 29, 2023
c0f2b7f
address reviewer feedback
cewert Oct 31, 2023
bd9a451
only quickplay on search page if search results are in focus
cewert Oct 31, 2023
034c485
use child count to track state of search results
cewert Oct 31, 2023
fd9b50c
validate search quick play node and return focus after a query with n…
cewert Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions components/search/SearchResults.brs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@ function onKeyEvent(key as string, press as boolean) as boolean
else if key = "right"
m.searchSelect.setFocus(true)
return true
else if key = "play"
print "play was pressed from search results"
if m.searchSelect.rowItemFocused <> invalid
cewert marked this conversation as resolved.
Show resolved Hide resolved
m.top.quickPlayNode = m.searchSelect.content.getChild(m.searchSelect.rowItemFocused[0]).getChild(m.searchSelect.rowItemFocused[1])
return true
end if
end if
return false

Expand Down
1 change: 1 addition & 0 deletions source/ShowScenes.brs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,6 +855,7 @@ end function
function CreateSearchPage()
' Search + Results Page
group = CreateObject("roSGNode", "searchResults")
group.observeField("quickPlayNode", m.port)
options = group.findNode("searchSelect")
options.observeField("itemSelected", m.port)

Expand Down