Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add quickplay support to search results #1456

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Add quickplay support to search results #1456

merged 7 commits into from
Oct 31, 2023

Conversation

cewert
Copy link
Member

@cewert cewert commented Oct 29, 2023 •
edited
Loading

Changes

  • Observe quickPlayNode and update it with the focused item when play is pressed
  • Only allow focus to leave keyboard if there are search results data

Issues

Fixes #1455

@cewert cewert requested a review from a team as a code owner October 29, 2023 02:39
1hitsong
1hitsong suggested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@1hitsong 1hitsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found another exception path.

  1. Go to search
  2. Type something that gets results
  3. Navigate to search result - just hover over, don't click on it
  4. Navigate back to keyboard and type garbage so results go away
  5. Press Play button on remote

@cewert cewert merged commit 44aac6b into jellyfin:unstable Oct 31, 2023
9 checks passed
@cewert cewert deleted the quickplay-search branch October 31, 2023 21:05
@cewert cewert added the feature A new feature that currently doesn't exist. label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roidy roidy roidy left review comments

@1hitsong 1hitsong 1hitsong approved these changes

Assignees
No one assigned
Labels
feature A new feature that currently doesn't exist.
Projects
Ongoing development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quick Play not supported on the Search page
3 participants
@cewert @1hitsong @roidy