Implement ykb tnye fixes

src/app.ts

@@ -6,6 +6,4 @@ import './css/jellyfin.css';
 
 window.mediaElement = document.getElementById('video-player');
 
-window.playlist = [];
-window.currentPlaylistIndex = -1;
 window.repeatMode = RepeatMode.RepeatNone;

src/components/__tests__/jellyfinApi.test.ts

@@ -1,8 +1,8 @@
 import { JellyfinApi } from '../jellyfinApi';
 
 const setupMockCastSenders = (): void => {
-    const getSenders = (): Array<any> => [{ id: 'thisIsSenderId' }];
-    const getInstance = (): any => ({ getSenders });
+    const getSenders = (): Array<any> => [{ id: 'thisIsSenderId' }]; // eslint-disable-line @typescript-eslint/no-explicit-any
+    const getInstance = (): any => ({ getSenders }); // eslint-disable-line @typescript-eslint/no-explicit-any
 
     // @ts-expect-error cast is already defined globally, however since we're mocking it we need to redefine it.
     global.cast = {

src/components/codecSupportHelper.ts

@@ -93,9 +93,20 @@ export function getMaxBitrateSupport(): number {
 /**
  * Get the max supported video width the active Cast device supports.
  * @param deviceId - Cast device id.
+ * @param codec - Video codec.
  * @returns Max supported width.
  */
-export function getMaxWidthSupport(deviceId: number): number {
+export function getMaxWidthSupport(deviceId: number, codec?: string): number {
+    if (codec === 'h264') {
+        // with HLS, it will produce a manifest error if we
+        // send any stream larger than the screen size...
+        return window.innerWidth;
+    }
+
+    // mkv playback can use the device limitations.
+    // The devices are capable of decoding and downscaling,
+    // they just refuse to do it with HLS. This increases
+    // the rate of direct playback.
     switch (deviceId) {
         case deviceIds.ULTRA:
         case deviceIds.CCGTV:

src/components/commandHandler.ts

@@ -1,5 +1,5 @@
-import { getReportingParams } from '../helpers';
-import {
+import { getReportingParams, TicksPerSecond } from '../helpers';
+import type {
     DataMessage,
     DisplayRequest,
     PlayRequest,
@@ -8,6 +8,7 @@ import {
     SetRepeatModeRequest,
     SupportedCommands
 } from '../types/global';
+import { AppStatus } from '../types/appStatus';
 import {
     translateItems,
     shuffle,
@@ -16,16 +17,12 @@ import {
     setSubtitleStreamIndex,
     seek
 } from './maincontroller';
-
 import { reportPlaybackProgress } from './jellyfinActions';
-
-import { playbackManager } from './playbackManager';
-
+import { PlaybackManager } from './playbackManager';
 import { DocumentManager } from './documentManager';
 
 export abstract class CommandHandler {
     private static playerManager: framework.PlayerManager;
-    private static playbackManager: playbackManager;
     private static supportedCommands: SupportedCommands = {
         DisplayContent: CommandHandler.displayContentHandler,
         Identify: CommandHandler.IdentifyHandler,
@@ -52,12 +49,8 @@ export abstract class CommandHandler {
         VolumeUp: CommandHandler.VolumeUpHandler
     };
 
-    static configure(
-        playerManager: framework.PlayerManager,
-        playbackManager: playbackManager
-    ): void {
+    static configure(playerManager: framework.PlayerManager): void {
         this.playerManager = playerManager;
-        this.playbackManager = playbackManager;
     }
 
     static playNextHandler(data: DataMessage): void {
@@ -89,36 +82,33 @@ export abstract class CommandHandler {
     }
 
     static displayContentHandler(data: DataMessage): void {
-        if (!this.playbackManager.isPlaying()) {
+        if (!PlaybackManager.isPlaying()) {
             DocumentManager.showItemId((<DisplayRequest>data.options).ItemId);
         }
     }
 
     static nextTrackHandler(): void {
-        if (
-            window.playlist &&
-            window.currentPlaylistIndex < window.playlist.length - 1
-        ) {
-            this.playbackManager.playNextItem({}, true);
+        if (PlaybackManager.hasNextItem()) {
+            PlaybackManager.playNextItem({}, true);
         }
     }
 
     static previousTrackHandler(): void {
-        if (window.playlist && window.currentPlaylistIndex > 0) {
-            this.playbackManager.playPreviousItem({});
+        if (PlaybackManager.hasPrevItem()) {
+            PlaybackManager.playPreviousItem({});
         }
     }
 
     static setAudioStreamIndexHandler(data: DataMessage): void {
         setAudioStreamIndex(
-            this.playbackManager.playbackState,
+            PlaybackManager.playbackState,
             (<SetIndexRequest>data.options).index
         );
     }
 
     static setSubtitleStreamIndexHandler(data: DataMessage): void {
         setSubtitleStreamIndex(
-            this.playbackManager.playbackState,
+            PlaybackManager.playbackState,
             (<SetIndexRequest>data.options).index
         );
     }
@@ -144,13 +134,17 @@ export abstract class CommandHandler {
     }
 
     static IdentifyHandler(): void {
-        if (!this.playbackManager.isPlaying()) {
+        if (!PlaybackManager.isPlaying()) {
+            if (!PlaybackManager.isBuffering()) {
+                DocumentManager.setAppStatus(AppStatus.Waiting);
+            }
+
             DocumentManager.startBackdropInterval();
         } else {
             // When a client connects send back the initial device state (volume etc) via a playbackstop message
             reportPlaybackProgress(
-                this.playbackManager.playbackState,
-                getReportingParams(this.playbackManager.playbackState),
+                PlaybackManager.playbackState,
+                getReportingParams(PlaybackManager.playbackState),
                 true,
                 'playbackstop'
             );
@@ -159,8 +153,8 @@ export abstract class CommandHandler {
 
     static SeekHandler(data: DataMessage): void {
         seek(
-            this.playbackManager.playbackState,
-            (<SeekRequest>data.options).position * 10000000
+            PlaybackManager.playbackState,
+            (<SeekRequest>data.options).position * TicksPerSecond
         );
     }
 

src/components/deviceprofileBuilder.ts

@@ -45,6 +45,7 @@ let profileOptions: ProfileOptions;
 let currentDeviceId: number;
 
 /**
+ * Create and return a new ProfileCondition
  * @param Property - What property the condition should test.
  * @param Condition - The condition to test the values for.
  * @param Value - The value to compare against.
@@ -66,13 +67,16 @@ function createProfileCondition(
 }
 
 /**
+ * Get container profiles
+ * @todo Why does this always return an empty array?
  * @returns Container profiles.
  */
 function getContainerProfiles(): Array<ContainerProfile> {
     return [];
 }
 
 /**
+ * Get response profiles
  * @returns Response profiles.
  */
 function getResponseProfiles(): Array<ResponseProfile> {
@@ -87,6 +91,7 @@ function getResponseProfiles(): Array<ResponseProfile> {
 }
 
 /**
+ * Get direct play profiles
  * @returns Direct play profiles.
  */
 function getDirectPlayProfiles(): Array<DirectPlayProfile> {
@@ -150,6 +155,7 @@ function getDirectPlayProfiles(): Array<DirectPlayProfile> {
 }
 
 /**
+ * Get codec profiles
  * @returns Codec profiles.
  */
 function getCodecProfiles(): Array<CodecProfile> {
@@ -224,7 +230,7 @@ function getCodecProfiles(): Array<CodecProfile> {
             createProfileCondition(
                 ProfileConditionValue.Width,
                 ProfileConditionType.LessThanEqual,
-                maxWidth.toString(),
+                getMaxWidthSupport(currentDeviceId, 'h264').toString(),
                 true
             )
         ],
@@ -271,7 +277,7 @@ function getCodecProfiles(): Array<CodecProfile> {
             createProfileCondition(
                 ProfileConditionValue.Width,
                 ProfileConditionType.LessThanEqual,
-                maxWidth.toString(),
+                getMaxWidthSupport(currentDeviceId).toString(),
                 true
             )
         ],
@@ -297,6 +303,7 @@ function getCodecProfiles(): Array<CodecProfile> {
 }
 
 /**
+ * Get transcoding profiles
  * @returns Transcoding profiles.
  */
 function getTranscodingProfiles(): Array<TranscodingProfile> {
@@ -375,6 +382,7 @@ function getTranscodingProfiles(): Array<TranscodingProfile> {
 }
 
 /**
+ * Get subtitle profiles
  * @returns Subtitle profiles.
  */
 function getSubtitleProfiles(): Array<SubtitleProfile> {

src/components/documentManager.ts

@@ -1,17 +1,16 @@
 import type { BaseItemDto } from '@jellyfin/sdk/lib/generated-client';
-
-import { parseISO8601Date } from '../helpers';
+import { AppStatus } from '../types/appStatus';
+import { parseISO8601Date, TicksPerSecond, ticksToSeconds } from '../helpers';
 import { JellyfinApi } from './jellyfinApi';
 import { deviceIds, getActiveDeviceId } from './castDevices';
 
 export abstract class DocumentManager {
     // Duration between each backdrop switch in ms
     private static backdropPeriodMs: number | null = 30000;
     // Timer state - so that we don't start the interval more than necessary
-    private static backdropTimer = 0;
+    private static backdropTimer: NodeJS.Timer | null = null;
 
-    // TODO make enum
-    private static status = '';
+    private static status = AppStatus.Unset;
 
     /**
      * Hide the document body on chromecast audio to save resources
@@ -181,7 +180,7 @@ export abstract class DocumentManager {
             }
 
             // Switch visible view!
-            this.setAppStatus('details');
+            this.setAppStatus(AppStatus.Details);
         });
     }
 
@@ -277,7 +276,7 @@ export abstract class DocumentManager {
      * to the corresponding one.
      * @param status - to set
      */
-    public static setAppStatus(status: string): void {
+    public static setAppStatus(status: AppStatus): void {
         this.status = status;
         document.body.className = status;
     }
@@ -286,7 +285,7 @@ export abstract class DocumentManager {
      * Get the status of the app
      * @returns app status
      */
-    public static getAppStatus(): string {
+    public static getAppStatus(): AppStatus {
         return this.status;
     }
 
@@ -390,9 +389,9 @@ export abstract class DocumentManager {
      * Stop the backdrop rotation
      */
     public static clearBackdropInterval(): void {
-        if (this.backdropTimer !== 0) {
+        if (this.backdropTimer !== null) {
             clearInterval(this.backdropTimer);
-            this.backdropTimer = 0;
+            this.backdropTimer = null;
         }
     }
 
@@ -416,11 +415,9 @@ export abstract class DocumentManager {
             return;
         }
 
-        this.backdropTimer = <any>(
-            setInterval(
-                () => DocumentManager.setRandomUserBackdrop(),
-                this.backdropPeriodMs
-            )
+        this.backdropTimer = setInterval(
+            () => DocumentManager.setRandomUserBackdrop(),
+            this.backdropPeriodMs
         );
 
         await this.setRandomUserBackdrop();
@@ -435,7 +432,7 @@ export abstract class DocumentManager {
             this.backdropPeriodMs = period;
 
             // If the timer was running, restart it
-            if (this.backdropTimer !== 0) {
+            if (this.backdropTimer !== null) {
                 // startBackdropInterval will also clear the previous one
                 this.startBackdropInterval();
             }
@@ -605,9 +602,8 @@ export abstract class DocumentManager {
      * @returns human readable position
      */
     private static formatRunningTime(ticks: number): string {
-        const ticksPerHour = 36000000000;
-        const ticksPerMinute = 600000000;
-        const ticksPerSecond = 10000000;
+        const ticksPerMinute = TicksPerSecond * 60;
+        const ticksPerHour = ticksPerMinute * 60;
 
         const parts: string[] = [];
 
@@ -629,7 +625,7 @@ export abstract class DocumentManager {
             parts.push(minutes.toString());
         }
 
-        const seconds: number = Math.floor(ticks / ticksPerSecond);
+        const seconds: number = Math.floor(ticksToSeconds(ticks));
 
         if (seconds < 10) {
             parts.push(`0${seconds.toString()}`);

src/components/fetchhelper.ts

@@ -3,6 +3,7 @@
  * @param request - Custom request object, mostly modeled after RequestInit.
  * @returns response promise
  */
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 function getFetchPromise(request: any): Promise<Response> {
     const headers = request.headers || {};
 
@@ -102,6 +103,7 @@ function paramsToString(params: Record<string, string>): string {
  * @param request - RequestInit-like structure but with url/type/timeout parameters as well
  * @returns response promise, may be automatically unpacked based on request datatype
  */
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export async function ajax(request: any): Promise<Response | string> {
     if (!request) {
         throw new Error('Request cannot be null');