Implement ykb tnye fixes #465
Conversation
…y has a useful position
… when it shouldn't
# Conflicts: # src/components/codecSupportHelper.ts # src/components/deviceprofileBuilder.ts # src/components/documentManager.ts # src/components/jellyfinActions.ts # src/components/maincontroller.ts # src/components/playbackManager.ts # src/helpers.ts
|
Can you rebase the pull request (again) now that #464 is merged? |
There was a problem hiding this comment.
Unfortunately Google screwed up my registration for the Google Cast Developer Console and their support is slow, so I'm unable to test this. The code changes look fine though and we can always fix any newly introduces bugs. The deployment is called unstable with a reason :p.
Thank you for the first PR! Looking forward to the next.
|
At last, the unstable branch actually does something and makes the Chromecast actually useable! We're looking forward to the next PRs that (hopefully) figure out:
The only regression I've seen is that documentmanager with the backdrops and item details screen no longer seems to show but I believe that had something to do with one of the dependencies that was automerged over two years ago. |
|
Thanks for your enthusiasm @neopc10! To answer some things:
Half of this list is impossible or not related to this repository:
Likely not possible because browsers do not support MKV files (only WEBM which is a subset) and the cast receiver effectively runs in a browser.
Haven't read too much into CAF but this should be possible
Unlikely to happen in the foreseeable future because I don't want a proprietary library included in the app. This prevents us from publishing to F-Droid unless we build two versions of the app which I don't want. It may also cause issues with publishing to the Amazon Appstore (I have not checked the requirements to confirm this).
Up to the jellyfin-vue maintainers, open an issue in their repository. Good to know is that I do plan on documenting the custom messages our receiver implements.
Let's wait for Jellyfin 10.9 first 😉
I haven't tested the unstable version after merging this PR but I did test it yesterday and backdrops worked for me at that time. So it might be a regression or a bug that only happens in certain scenarios. edit: This is indeed broken right now
Dependencies are not automatically merged, I've manually merged them for a while now. |
In the last couple of years quite some developers prepared much needed fixes for Jellyfin chromecast. @YouKnowBlom and @tnyeanderson and others compiled a list of most annoying issues in a dedicated branch https://github.com/YouKnowBlom/jellyfin-chromecast/tree/misc-fixes-tnye-merge and almost succeeded in releasing the fixes when a small but potentially irritating issue brought the release to a halt. See #107 (comment)
The present PR is a plain merge of above branch into the unstable, with appropriate conflict resolutions, intended to release the compiled fixes and provide a clean state for moving forward with other issues. The present solution works a lot better then before, but in order to keep this PR clean no additional fixes have been included. So the above irritating issue for instance is still there. Further fixes for this and other issues will be offered in additional PR's