Refactor parts of Plane into a plane-common crate (DIS-2967)
#849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
paulgb
changed the title
client crateclient crate (DIS-2967)
paulgb
changed the title
client crate (DIS-2967)plane-common crate (DIS-2967)
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to a33face in 1 minute and 7 seconds
More details
- Looked at
3379lines of code in102files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_m24uWA9S6sFjgjAv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
michaelsilver
approved these changes
Dec 3, 2024
Fixed, thanks! |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 164567a in 36 seconds
More details
- Looked at
98lines of code in6files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_50RrllTWWWkURskQ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main
planecrate contains a client, but depending on it in another project requires bringing in all of Plane, including the openssl dependency. This breaks the client (and other pieces) out into aplane-commoncrate with the parts needed to "consume" Plane as a client, and a crate for Plane itself (in particular, without the database and ACME stuff, which bring in other dependencies that can be hard to wrangle).This looks like a huge PR but there is essentially no net new code here; files are just moved around. A few notes:
plane-dynamic; it was a hack to make tests compile faster but it should be less necessary now that we have broken up Plane into several crates.planedepends onplane-common, butplane-commondoes NOT depend onplane, so things likeExponentialBackoff(used by the client to manage reconnects) go inplane-common.Todo:
test_get_metricsandbackend_lifecycletests to pass.plane-common?