Fix Plane docker builds

[paulgb]

Broken by #849.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
plane	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 6, 2024 7:46pm

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to ad29fcf in 12 seconds

More details

• Looked at 89 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. docker/Dockerfile:1

• Draft comment:
  Consider using a more general Rust version tag like rust:bullseye unless a specific version is required. This ensures you get the latest compatible version automatically.
• Reason this comment was not posted:
  Confidence changes required: 33%
  The Dockerfile is using a specific Rust version tag rust:1.83-bullseye. This is generally fine, but it's important to ensure that this version is compatible with the rest of the codebase and dependencies. If the project requires a specific version, it should be documented. Otherwise, consider using a more general tag like rust:bullseye to automatically get the latest compatible version.

2. docker/quickstart/Dockerfile:4

• Draft comment:
  Consider using a more general Rust version tag like rust:bullseye unless a specific version is required. This ensures you get the latest compatible version automatically.
• Reason this comment was not posted:
  Confidence changes required: 33%
  The same issue with the specific Rust version tag applies here as well. It's important to ensure consistency across Dockerfiles.

3. docker/Dockerfile:34

• Draft comment:
  The cargo build -p plane --release --locked command is repeated. Consider removing the redundant build command to optimize the build process.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The cargo build -p plane --release --locked command is repeated twice in both Dockerfiles. This redundancy can be removed to optimize the build process.

4. docker/quickstart/Dockerfile:37

• Draft comment:
  The cargo build -p plane --release --locked command is repeated. Consider removing the redundant build command to optimize the build process.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The cargo build -p plane --release --locked command is repeated twice in both Dockerfiles. This redundancy can be removed to optimize the build process.

Workflow ID: wflow_91aouc9uMshBqtsc

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 01ce867 in 3 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. docker/build-quickstart.sh:1

• Draft comment:
  Consider using #!/bin/bash for better compatibility and robustness, especially if the script becomes more complex in the future.
• Reason this comment was not posted:
  Confidence changes required: 33%
  The script uses #!/bin/sh which is fine for simple scripts, but #!/bin/bash is more robust for complex scripts. However, since this script is simple, sh is acceptable.

Workflow ID: wflow_HQRlwEcz9xkdcy2p

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.