Update ci #45
Update ci #45
Conversation
|
I was experimenting with @gmantele's ivoa-std/ivoatex#141 update-ci PR as an alternative to #44. It doesn't seem to work here for reasons I haven't investigated - maybe I was doing something wrong. Close this PR in favour of #44, which does work, instead. |
|
See https://github.com/ivoa-std/DALI/actions/runs/12049700164 for CI build report. |
|
Tried again with the merged-to-master ivoatex, still broken. |
|
It should be fixed by ivoa-std/ivoatex#142 |
|
Yes, successful CI using the current master branch of ivoatex. This branch can now be merged. |
|
So... it looks like my earlier optimism was premature, the CI is broken for this update, at least by the time it's been merged to master. Since it was working on the PR branch pre-merge I don't understand this - but then I don't understand lots about github CI. I can see roughly what's wrong in the build error log, but I don't know how to fix it. @gmantele could you take another look? |
| name: Update PDF Preview | ||
|
|
||
| env: | ||
| doc_name: DALI | ||
| doc_name : |
There was a problem hiding this comment.
doc_name isn't set here, so later in L38 the ${{ env.doc_name }}-draft.pdf substitution becomes -draft.pdf. It "passed" (i.e. didn't run) in the PR because this workflow will only run on pushes to the main branch.
Is doc_name supposed to be set dynamically somewhere?
There was a problem hiding this comment.
You're right. The update-ci target does not set this field in the CI configuration file. It was already done like that before. But sure, maybe we can do better by doing that automatically with this Makefile target.
Sorry again for this issue.
There was a problem hiding this comment.
Actually, looking now at the Makefile code, we are already doing this automatically when DOCNAME is set in the Makefile. But the problem is due to the spaces I have added between doc_name and the :. What a stupid mistake...sorry, I push a new PullRequest to fix this. I hope this time it will be OK.
There was a problem hiding this comment.
See PullRequest ivoa-std/ivoatex#143 for a fix
No description provided.