Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parquet responseformat #43

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Conversation

mbtaylor
Copy link
Member

Parquet files becoming more common. Having a suitable RESPONSEFORMAT alias will make it more convenient to request service table output in parquet format. This was requested by Mario Juric in the Apps telecon on 5 Nov 2024. I don't see any disadvantage or negative impact of adding this.

The parquet entry made the table wider, so delete an empty column
and avoid an indent to stop the hbox overflowing.
@pdowler
Copy link
Collaborator

pdowler commented Nov 27, 2024

If you change the action to actions/upload-artifact@v4 the build will probably succeed

@mbtaylor
Copy link
Member Author

You're right. I made the CI fix at #44, so if you approve and merge that, then this one should be good to merge too.

@mbtaylor
Copy link
Member Author

Following a lot of CI fun, the plan is now to merge #45 (not #44), and then merge this one on top.

@pdowler
Copy link
Collaborator

pdowler commented Nov 27, 2024

I've merged PR #45 and forced the buikld, but this still uses the v1 action, despite showing no diff and not being behind the master branch.

maybe you need to update vs master to trigger it properly?? I was expecting to be able to do that but can't

@mbtaylor
Copy link
Member Author

Not using the v1 action, it's failing for a different reason now. I've commented further on this at #45.

@pdowler
Copy link
Collaborator

pdowler commented Nov 27, 2024

from the comments in $45, looks like doc_name in preview.yaml is not set properly

@mbtaylor
Copy link
Member Author

Now I'm confused. Again. The build is failing with a report about using actions/upload-artifact: v1. But it should be merging into ivoa-std:master which now has an updated build.yml (actions/upload-artifact@v4, no v1s). Nothing in the branch belonging to this PR touches the CI. Do I have to make another PR with this branch?

@pdowler
Copy link
Collaborator

pdowler commented Nov 28, 2024

Can you merge master into your branch and push that to your fork? I think that will sort it out

@pdowler
Copy link
Collaborator

pdowler commented Nov 28, 2024

usually the summary/checks say when a PR is behind (missing commits from) master, but here it never said that. Strange.

@pdowler pdowler merged commit 58b11ca into ivoa-std:master Nov 28, 2024
1 check passed
@mbtaylor
Copy link
Member Author

Well at least I managed to merge this branch ... but I see the CI is still failing, for a different reason now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants