feat(protocol): Add computation_cost_burned field to GasCostSummary #3944
Conversation
cyberphysic4l
added
the
tokenomics
crates/iota-types/src/effects/mod.rs
Outdated
| @@ -43,7 +43,7 @@ pub const APPROX_SIZE_OF_EXECUTION_STATUS: usize = 120; | |||
| // Approximate size of `EpochId` type in bytes | |||
| pub const APPROX_SIZE_OF_EPOCH_ID: usize = 10; | |||
| // Approximate size of `GasCostSummary` type in bytes | |||
| pub const APPROX_SIZE_OF_GAS_COST_SUMMARY: usize = 40; | |||
| pub const APPROX_SIZE_OF_GAS_COST_SUMMARY: usize = 40; // TODO: Update this | |||
There was a problem hiding this comment.
do we have an issue to track this maybe?
There was a problem hiding this comment.
Well I actually think we can update this and get rid of the TODO. Do you know if this estimation of size is as simple as 10 bytes per u64 value of something? We have one additional u64 field so perhaps the new approx size is just 50 instead of 40...
| @@ -203,6 +203,9 @@ impl TryFrom<StoredCheckpoint> for RpcCheckpoint { | |||
| end_of_epoch_data, | |||
| epoch_rolling_gas_cost_summary: GasCostSummary { | |||
| computation_cost: checkpoint.computation_cost as u64, | |||
| // TODO_FIXED_BASE_FEE: update computation cost burned in checkpoint to be used | |||
| // here. | |||
There was a problem hiding this comment.
A link to an issue maybe?
There was a problem hiding this comment.
LGTM, lets merge it after
#3831
and
iotaledger/iota-rust-sdk#20
since this will require updated expectations and snapshots.
There was a problem hiding this comment.
LGTM, lets merge it after #3831 and iotaledger/iota-rust-sdk#20 since this will require updated expectations and snapshots.
Second that.
|
I removed the current light client checkpoints so those tests will fail again. I'd like to wait for #3926 to re-do those |
muXxer
force-pushed
the
feat/gascostsummaryburned
branch
from
8756c8d to
0e5aca9
Compare
muXxer
force-pushed
the
feat/gascostsummaryburned
branch
from
d173ef1 to
8e46236
Compare
|
|
|
This pull request has been deployed to Vercel. Latest commit: afe08dc ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-2r7af1m9v.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: afe08dc ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-lw8ngr03w.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: afe08dc ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-i199qhj5s.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 42c4fde ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-9pjvb3gx1.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 42c4fde ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-bof8u39qe.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 42c4fde ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-342vqbvc4.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 2bb867e ✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-qems1j3b3.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 2bb867e ✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-p4130azn5.vercel.app |
|
This pull request has been deployed to Vercel. Latest commit: 2bb867e ✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-2xwb4nv88.vercel.app |
Description of change
Added field computation_cost_burned to the widely used GasCostSummary type to prevent creating V2 of this type in upcoming protocol changes to burn a fixed base fee for all transactions.
Links to any relevant issues
Foundations for #3122
How the change has been tested
Existing tests pass