Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add computation_cost_burned and safe_mode_computation_rewards_burned fields #4008

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

muXxer
Copy link
Contributor

@muXxer muXxer commented Nov 11, 2024

Description of change

This PR adds the computation_cost_burned to more parts in the code, and it also adds safe_mode_computation_rewards_burned to the system state.

It might need to be included in #3517, and the types should be properly versioned in case they are breaking.

Links to any relevant issues

Continuation of #3944

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@muXxer muXxer added the node Issues related to the Core Node team label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-protocol node Issues related to the Core Node team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants