Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove move object has_public_transfer #3831

Merged
merged 68 commits into from
Nov 8, 2024
Merged

refactor: Remove move object has_public_transfer #3831

merged 68 commits into from
Nov 8, 2024

Conversation

jkrvivian
Copy link
Contributor

@jkrvivian jkrvivian commented Oct 31, 2024 •
edited
Loading

Description of change

has_public_transfer is no longer used to determine whether a transaction can transfer this object. Instead, it is always calculated from the objects type when loaded in execution. So we remove it in this PR.

It's based on the removal of has_publich_transfer in iota-rust-sdk as well, here's the PR: iotaledger/iota-rust-sdk#18

Links to any relevant issues

#2092

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Enhancement

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have checked that new and existing unit tests pass locally with my changes

@jkrvivian jkrvivian added the node Issues related to the Core Node team label Oct 31, 2024
@jkrvivian jkrvivian self-assigned this Oct 31, 2024
@jkrvivian jkrvivian force-pushed the core-node/fix/remove-MoveObject-has_public_transfer branch 2 times, most recently from e27d0e0 to d71c9b8 Compare November 1, 2024 07:25
@thibault-martinez thibault-martinez mentioned this pull request Nov 1, 2024
Closed
18 tasks
@jkrvivian jkrvivian marked this pull request as ready for review November 4, 2024 07:38
@jkrvivian jkrvivian force-pushed the core-node/fix/remove-MoveObject-has_public_transfer branch from 55e637b to b0e4706 Compare November 4, 2024 08:53
alexsporn
alexsporn reviewed Nov 4, 2024
View reviewed changes
Copy link
Member

@alexsporn alexsporn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valeriyr can you please take a close look at this since this flag is explicitly marked with safety comments.

Is this really not required by the public API users?

iota-execution/latest/iota-adapter/src/programmable_transactions/context.rs Show resolved Hide resolved
iota-execution/v0/iota-adapter/src/programmable_transactions/context.rs Show resolved Hide resolved
iota-execution/v0/iota-adapter/src/programmable_transactions/context.rs Outdated Show resolved Hide resolved
@samuel-rufi samuel-rufi requested a review from lzpap November 4, 2024 10:09
@muXxer muXxer mentioned this pull request Nov 4, 2024
Closed
@jkrvivian jkrvivian force-pushed the core-node/fix/remove-MoveObject-has_public_transfer branch from 1a3ac47 to 0283c5d Compare November 4, 2024 12:25
@alexsporn alexsporn added this to the Testnet Launch v1.0.0-rc milestone Nov 5, 2024
@muXxer muXxer mentioned this pull request Nov 5, 2024
Merged
@jkrvivian jkrvivian force-pushed the core-node/fix/remove-MoveObject-has_public_transfer branch from acebb7e to 6c6e8dd Compare November 5, 2024 10:22
@jkrvivian jkrvivian requested review from a team as code owners November 5, 2024 11:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 5db8d92

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-culkmcp9t.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 5db8d92

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-41h75peue.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

This pull request has been deployed to Vercel.

Latest commit: 5db8d92

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-hajqwgt9r.vercel.app

@begonaalvarezd begonaalvarezd mentioned this pull request Nov 8, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: 767b8c6

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-ax8snlhc9.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: 767b8c6

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-4ezwzmm6m.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: 767b8c6

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-mus4tdn52.vercel.app

valeriyr
valeriyr approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@valeriyr valeriyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@alexsporn alexsporn mentioned this pull request Nov 8, 2024
Merged
@jkrvivian jkrvivian force-pushed the core-node/fix/remove-MoveObject-has_public_transfer branch from 767b8c6 to f304d7a Compare November 8, 2024 09:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: f304d7a

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-paeij2wzv.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: f304d7a

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-8sckoimps.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: f304d7a

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-kb0hqlk93.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: e61cd2a

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-jrkxa9imr.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: e61cd2a

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-pwbnb5x80.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: e61cd2a

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-eq236a4ak.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: 07ab05b

✅ Preview: https://apps-backend-29a719c9ccbdb9b80c97b599a599d8953354da-4khh7vt76.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: 07ab05b

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-mvt9bpq89.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request has been deployed to Vercel.

Latest commit: 07ab05b

✅ Preview: https://iota-rebased-explorer-092603f1de8088243ccb8b861b23e-o7a8vf6vu.vercel.app

thibault-martinez
thibault-martinez reviewed Nov 8, 2024
View reviewed changes
crates/iota-light-client/src/bin/light_client.rs
@@ -149,9 +151,13 @@ mod tests {
Ok(())
}

// TODO: why is this function here with hardcoded indexes?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth opening an issue to revisit?

@alexsporn alexsporn merged commit 1a2e8e4 into develop Nov 8, 2024
38 of 40 checks passed
@alexsporn alexsporn deleted the core-node/fix/remove-MoveObject-has_public_transfer branch November 8, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muXxer muXxer muXxer approved these changes

@alexsporn alexsporn alexsporn left review comments

@valeriyr valeriyr valeriyr approved these changes

@lucas-tortora lucas-tortora lucas-tortora approved these changes

@miker83z miker83z miker83z approved these changes

@kodemartin kodemartin kodemartin approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@thibault-martinez thibault-martinez thibault-martinez approved these changes

@lzpap lzpap Awaiting requested review from lzpap

@Thoralf-M Thoralf-M Awaiting requested review from Thoralf-M

Assignees

@jkrvivian jkrvivian

Labels
documentation Improvements or additions to documentation node Issues related to the Core Node team
Projects
None yet
Milestone
Testnet Launch v0.7.x-rc
Development

Successfully merging this pull request may close these issues.