Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove try_from_dtos #1817

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

Thoralf-M
Copy link
Member

Description of change

Remove try_from_dtos() since it's not needed anymore

Links to any relevant issues

Closes #1713

Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these used in the bindings core?

@Thoralf-M
Copy link
Member Author

Aren't these used in the bindings core?

Now not anymore :trollface:

DaughterOfMars
DaughterOfMars previously approved these changes Jan 9, 2024
@Thoralf-M Thoralf-M linked an issue Jan 9, 2024 that may be closed by this pull request
@thibault-martinez thibault-martinez merged commit 8647df1 into iotaledger:2.0 Jan 9, 2024
36 checks passed
@Thoralf-M Thoralf-M deleted the remove-try_from_dtos branch January 9, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if more dtos can be made private/removed
3 participants