Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if more dtos can be made private/removed #1713

Closed
Thoralf-M opened this issue Nov 29, 2023 · 6 comments · Fixed by #1817
Closed

Check if more dtos can be made private/removed #1713

Thoralf-M opened this issue Nov 29, 2023 · 6 comments · Fixed by #1817
Assignees
@Thoralf-M
Labels
m-types Module - Types t-cleanup Task - Cleanup
Milestone
v2.0.0 (Q4 2023)

Comments

@Thoralf-M
Copy link
Member

Thoralf-M commented Nov 29, 2023 •
edited
Loading

#1712 makes the output dtos private and structs like InputSigningData, RemainderDataDto had a dto just because of the OutputDto, so InputSigningDataDto and maybe others can now also be removed/made private.
@Thoralf-M Thoralf-M added the m-types Module - Types label Nov 29, 2023
@github-project-automation github-project-automation bot moved this to Product Backlog in iota-sdk Nov 29, 2023
@Thoralf-M Thoralf-M mentioned this issue Nov 29, 2023
Merged
@thibault-martinez
Copy link
Member

Also OutputDataDto?

@Thoralf-M
Copy link
Member Author

UnlockConditionDto

@Thoralf-M Thoralf-M self-assigned this Nov 30, 2023
@Thoralf-M Thoralf-M moved this from Product Backlog to In Progress in iota-sdk Nov 30, 2023
@Thoralf-M Thoralf-M mentioned this issue Nov 30, 2023
Merged
@thibault-martinez
Copy link
Member

Remove try_from_dtoss ?

@thibault-martinez
Copy link
Member

PayloadDto ?

@Thoralf-M
Copy link
Member Author

Thoralf-M commented Nov 30, 2023 •
edited
Loading

AccountOutputDto, BasicOutputDto... can be private and removed if we find a better solution for the type field

@thibault-martinez thibault-martinez added this to the v2.0.0 milestone Dec 1, 2023
@thibault-martinez thibault-martinez added the t-cleanup Task - Cleanup label Dec 11, 2023
@Thoralf-M Thoralf-M mentioned this issue Jan 9, 2024
Merged
@Thoralf-M Thoralf-M moved this from In Progress to In Review in iota-sdk Jan 9, 2024
@Thoralf-M Thoralf-M linked a pull request Jan 9, 2024 that will close this issue
Remove try_from_dtos #1817
Merged
@thibault-martinez
Copy link
Member

Closed by #1817

@github-project-automation github-project-automation bot moved this from In Review to Done in iota-sdk Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thoralf-M Thoralf-M

Labels
m-types Module - Types t-cleanup Task - Cleanup
Projects
iota-sdk
Status: Done
Milestone
v2.0.0 (Q4 2023)
Development

Successfully merging a pull request may close this issue.

Remove try_from_dtos Thoralf-M/iota-sdk
2 participants
@thibault-martinez @Thoralf-M