Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify nodejs client and wallet #1119

Closed
wants to merge 21 commits into from

Conversation

Thoralf-M
Copy link
Member

Description of change

This PR cleans up the client and wallet nodejs rust bindings.

Links to any relevant issues

Closes #699

Replaces #1056

@thibault-martinez thibault-martinez changed the title Chore/bindings cleanup is alive Simplify nodejs client and wallet Sep 5, 2023
Brord van Wierst added 5 commits September 7, 2023 09:51
* unify error handling and responses

* wasm

* its something

* secret manager alignment

* error on callback fix

* listen error in wasm, madelisten async again
kwek20
kwek20 previously approved these changes Sep 7, 2023
kwek20
kwek20 previously approved these changes Sep 7, 2023
Copy link
Member

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts

@kwek20 kwek20 linked an issue Sep 11, 2023 that may be closed by this pull request
kwek20
kwek20 previously approved these changes Sep 11, 2023
Copy link

@DaughterOfMars DaughterOfMars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are breaking. Can't merge at 1.1

@kwek20
Copy link
Contributor

kwek20 commented Sep 11, 2023

Changes are breaking. Can't merge at 1.1

If you just mean the Error("") vs "", i can change that and add a todo? Sync methods can also be awaited, so user code doesnt change

@thibault-martinez
Copy link
Member

Changes are breaking. Can't merge at 1.1

If you just mean the Error("") vs "", i can change that and add a todo? Sync methods can also be awaited, so user code doesnt change

@kwek20 @DaughterOfMars any update on this?

@DaughterOfMars
Copy link

I don't know if that statement is true but even if it is I don't really like the changes that were made

@kwek20
Copy link
Contributor

kwek20 commented Sep 22, 2023

The statement is true :) lets merge. at the very least its cleaner than current code. can always opt not to close the issue.

@Thoralf-M Thoralf-M changed the base branch from 1.1 to develop October 2, 2023 07:37
@Thoralf-M Thoralf-M dismissed kwek20’s stale review October 2, 2023 07:37

The base branch was changed.

@Alex6323
Copy link
Contributor

What's the status of this PR btw?

@DaughterOfMars
Copy link

Waiting for @kwek20 to rebase it on 2.0

@kwek20 kwek20 closed this Oct 31, 2023
@kwek20
Copy link
Contributor

kwek20 commented Oct 31, 2023

closed in favour of the 2.0 PR

@kwek20 kwek20 mentioned this pull request Oct 31, 2023
3 tasks
@thibault-martinez thibault-martinez deleted the chore/bindings-cleanup-is-alive branch November 6, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate: Nodejs bindings wrapper type
5 participants