Chore/bindings: cleanup is alive 2.0 #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* unify error handling and responses * wasm * its something * secret manager alignment * error on callback fix * listen error in wasm, madelisten async again
thibault-martinez
requested changes
Nov 7, 2023
kwek20
force-pushed
the
chore/bindings-cleanup-is-alive
branch
from
0005505 to
72a5c32
Compare
…kwek20/iota-sdk into chore/bindings-cleanup-is-alive
|
Checked out suggestions form @DaughterOfMars, but decided it wasnt worth it now. new issue: #1746 Updated description TODOs |
|
merge? |
thibault-martinez
dismissed stale reviews from Thoralf-M, Alex6323, and DaughterOfMars
via
a0776af
thibault-martinez
approved these changes
Dec 12, 2023
Thoralf-M
approved these changes
Dec 12, 2023
Alex6323
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
TODO:
Align secretmanager with the wallet and client code (it doesnt have option, but gets returned aswill be done after secret rewriteArc<RwLock<>>so cant unwrap unless cloning nonsense, so cant use thebinding_glue!walletmaybe more?
Closes #699
Replaces #1119