Encode each attestation by version when sending over the wire #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsporn
changed the title
jonastheis
reviewed
Sep 19, 2023
Comment on lines
+205
to
+211
| if len(attestationsBytes) < 4 { | ||
| p.Events.Error.Trigger(ierrors.Errorf("failed to deserialize attestations, invalid attestation count"), id) | ||
|
|
||
| return | ||
| } | ||
|
|
||
| attestationCount := binary.LittleEndian.Uint32(attestationsBytes[0:4]) |
There was a problem hiding this comment.
Checking for the constant, using binary.LittleEndian package and having a manual readOffset seems to be a bit cumbersome. I think this would be much nicer with the stream package, here specifically ReadCollection
Comment on lines
+78
to
+82
| encodedAttestations := marshalutil.New() | ||
| encodedAttestations.WriteUint32(uint32(len(attestations))) | ||
| for _, att := range attestations { | ||
| iotagoAPI := lo.PanicOnErr(p.apiProvider.APIForVersion(att.ProtocolVersion)) | ||
| encodedAttestations.WriteBytes(lo.PanicOnErr(iotagoAPI.Encode(att))) |
There was a problem hiding this comment.
Instead of marshalutil we could use stream.WriteCollection
There was a problem hiding this comment.
a bytes buffer does not implement WriteSeeker, so could not use it here
There was a problem hiding this comment.
Ok then let's implement something like this https://stackoverflow.com/a/73679110 in the context of #284 so that we're able to use a bytes buffer with the stream package and replace this later
jonastheis
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.