Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode/Decode attestation one by one #252

Closed
jkrvivian opened this issue Aug 3, 2023 · 1 comment · Fixed by #351
Closed

Encode/Decode attestation one by one #252

jkrvivian opened this issue Aug 3, 2023 · 1 comment · Fixed by #351
Assignees
@alexsporn
Milestone
v1.0.0-beta

Comments

@jkrvivian
Copy link
Contributor

There are multiple attestations potentially spanning multiple epochs/versions, we need to use the correct API for each one.

file: pkg/network/protocols/core/protocol.go: SendAttestations, onAttestations
@jkrvivian jkrvivian converted this from a draft issue Aug 3, 2023
@alexsporn alexsporn self-assigned this Aug 8, 2023
@jonastheis
Copy link
Contributor

jonastheis commented Aug 15, 2023 •
edited
Loading

This can be done together with #189

@jonastheis jonastheis moved this from Must Haves to Hardening in iota-core Aug 15, 2023
@karimodm karimodm added this to the 1.0 RC milestone Sep 4, 2023
@jonastheis jonastheis moved this from Hardening to Backlog in iota-core Sep 4, 2023
@alexsporn alexsporn self-assigned this Sep 18, 2023
@alexsporn alexsporn moved this from Backlog to In Progress in iota-core Sep 18, 2023
@alexsporn alexsporn linked a pull request Sep 18, 2023 that will close this issue
Encode each attestation by version when sending over the wire #351
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in iota-core Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexsporn alexsporn

Labels
None yet
Projects
iota-core
Archived in project
Milestone
v1.0.0-beta
Development

Successfully merging a pull request may close this issue.

Encode each attestation by version when sending over the wire iotaledger/iota-core
4 participants
@karimodm @jonastheis @alexsporn @jkrvivian