Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot bug #86

Closed
wants to merge 1 commit into from
Closed

Fix plot bug #86

wants to merge 1 commit into from

Conversation

1abdelhalim
Copy link

Changes Made:

  • plot_track:

    • Fixed a bug causing a KeyError when accessing specific column names (longitude (degrees_east) and latitude (degrees_north)). Updated to use generic column names (longitude and latitude).

    • Aligned function expectations with the output of the standardise_df function from the fetchers.py module.

  • plot_transect:

    • Improved the plot_transect function to enhance readability and usability.

    • Updated the y-axis label to "Pressure (dbar)" for clarity.

    • Modified the data source from "depth (m)" to "pressure" (df["pressure"]) to accurately represent the plotted data.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 11, 2024

@1abdelhalim this PR has some conflicts and we will wait until GSoC results are in to work on this. Closing for now but we will re-open accordingly. Note that to fix this, we want to standardize the columns names and not try to catch for a specific case. That is b/c the request can change to have the units, making the original code here correct.

@ocefpaf ocefpaf closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants