Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have been facing key errors while using the function plot_track which is present in plotters.py file #90

Closed
Harish-2003 opened this issue Mar 5, 2024 · 4 comments

Comments

@Harish-2003
Copy link

image
this issue is adressed at pr #86
and also at pr #89 (in this pull request more info about readme file is added and also an label track is added

@ocefpaf
Copy link
Member

ocefpaf commented Mar 5, 2024

Hi @Harish-2003! Thanks for the issue and the PRs. We'll check them shortly. Note that, when pasting, code please do not use images b/c they make it quite hard to copy-n-paste for testing. They are also hard to search!

@Harish-2003
Copy link
Author

from gliderpy.fetchers import GliderDataFetcher
from matplotlib import pyplot as plt
from gliderpy.plotters import plot_track

glider_grab = GliderDataFetcher()

glider_grab.fetcher.dataset_id = "whoi_406-20160902T1700"

df = glider_grab.to_pandas()

plot_track(df)

this is the code which i was trying to run....
and yea sure will not use images from this time @ocefpaf

@ocefpaf
Copy link
Member

ocefpaf commented Apr 11, 2024

We should probably address this by figuring out why the units were dropped in the column labels and re-add them. My guess is that the response was changed from csvp to csv somewhere.

@ocefpaf
Copy link
Member

ocefpaf commented Jul 4, 2024

I believe this was fixed. This code was all re-written and the tests are passing. Closing this.

@ocefpaf ocefpaf closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants