Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeline feed: render mathematical content in the request comments #403

Merged
merged 2 commits into from
Sep 17, 2024
Merged

timeline feed: render mathematical content in the request comments #403

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d4d1ab
timeline feed: render mathematical content in the request comments
anikachurilova Aug 20, 2024
1dca41a
assets: optimise detection if timeline was updated
kpsherva Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions invenio_requests/assets/semantic-ui/js/invenio_requests/timeline/TimelineFeed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import { Pagination } from "../components/Pagination";
import RequestsFeed from "../components/RequestsFeed";
import { TimelineCommentEditor } from "../timelineCommentEditor";
import { TimelineCommentEventControlled } from "../timelineCommentEventControlled";
import _ from "lodash";

class TimelineFeed extends Component {
constructor(props) {
Expand All @@ -31,6 +32,16 @@ class TimelineFeed extends Component {
getTimelineWithRefresh();
}

componentDidUpdate(prevProps) {
const { timeline } = this.props;

const hasComments = timeline?.hits?.total > 0;
const hasNewComments = prevProps.timeline?.hits?.total !== timeline?.hits?.total;
if (hasComments && hasNewComments) {
window.MathJax?.typeset();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing mathjax as a requirement, how do we know this module has it in the window namespace?

}
}

componentWillUnmount() {
const { timelineStopRefresh } = this.props;
timelineStopRefresh();
Expand Down