timeline feed: render mathematical content in the request comments #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
anikachurilova
commented
Aug 20, 2024
anikachurilova
commented
- closes LaTeX rendering CERNDocumentServer/cds-rdm#133
ntarocco
reviewed
Aug 21, 2024
invenio_requests/assets/semantic-ui/js/invenio_requests/timeline/TimelineFeed.js
Outdated
Show resolved
Hide resolved
anikachurilova
force-pushed
the
LaTeX-rendering
branch
from
b8819b4 to
0d4d1ab
Compare
jrcastro2
approved these changes
Aug 29, 2024
ntarocco
reviewed
Sep 9, 2024
| componentDidUpdate(prevProps) { | ||
| const { timeline } = this.props; | ||
|
|
||
| if (!_.isEqual(prevProps.timeline, timeline) && timeline?.hits?.total > 0) { |
There was a problem hiding this comment.
While comparing timeline looks correct, it might be quite expensive... is there any other field, in the timeline object, that tell us that something changed?
I would also change the order of the conditions for performance:
timeline?.hits?.total > 0 && ...
kpsherva
force-pushed
the
LaTeX-rendering
branch
from
ad07bd2 to
1dca41a
Compare
jrcastro2
approved these changes
Sep 16, 2024
kpsherva
reviewed
Sep 17, 2024
| const hasComments = timeline?.hits?.total > 0; | ||
| const hasNewComments = prevProps.timeline?.hits?.total !== timeline?.hits?.total; | ||
| if (hasComments && hasNewComments) { | ||
| window.MathJax?.typeset(); |
There was a problem hiding this comment.
missing mathjax as a requirement, how do we know this module has it in the window namespace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.