Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: migrate CI to GH Actions #220

Merged
merged 1 commit into from
Dec 1, 2020
Merged

global: migrate CI to GH Actions #220

merged 1 commit into from
Dec 1, 2020

Conversation

ParthS007
Copy link
Member

closes #219

@ParthS007 ParthS007 self-assigned this Dec 1, 2020
@ParthS007 ParthS007 force-pushed the gh-actions branch 5 times, most recently from 8a897c6 to 059643d Compare December 1, 2020 14:29
@ParthS007
Copy link
Member Author

Build failing because of inveniosoftware/invenio-oauthclient#195

run-tests.sh Show resolved Hide resolved
@diegodelemos
Copy link
Member

diegodelemos commented Dec 1, 2020

Minor: Test requirements to be simplified through pytest-invenio like here.

@diegodelemos
Copy link
Member

Minor: pytest.ini to be updated according to cookiecutter-invenio-module's pytest.ini.

@diegodelemos
Copy link
Member

Minor: replace all occurences of .travis.yml (e.g.

[{package.json,.travis.yml}]
)

@ParthS007 ParthS007 force-pushed the gh-actions branch 2 times, most recently from 8b59f46 to bf74572 Compare December 1, 2020 15:28
python setup.py test && \
# Quit on unbound symbols
set -o nounset

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major: ⚠️ We are setting postgreqlX and mysqlX in the build matrix but we never call docker-services-cli here, so basically test won't be able to connect to a DB that isn't running.

check-manifest --ignore ".travis-*"
sphinx-build -qnNW docs docs/_build/html
docker-services-cli up ${DB}
python setup.py test
sphinx-build -qnNW -b doctest docs docs/_build/doctest
Copy link
Member

@diegodelemos diegodelemos Dec 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegodelemos diegodelemos merged commit 6fe136c into master Dec 1, 2020
@ParthS007 ParthS007 deleted the gh-actions branch December 2, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

global: migration to github-actions from travis
3 participants