-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global: migrate CI to GH Actions #220
Conversation
8a897c6
to
059643d
Compare
Build failing because of inveniosoftware/invenio-oauthclient#195 |
Minor: Test requirements to be simplified through |
Minor: |
Minor: replace all occurences of invenio-oauth2server/.editorconfig Line 38 in 02012fb
|
8b59f46
to
bf74572
Compare
python setup.py test && \ | ||
# Quit on unbound symbols | ||
set -o nounset | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major: postgreqlX
and mysqlX
in the build matrix but we never call docker-services-cli
here, so basically test won't be able to connect to a DB that isn't running.
check-manifest --ignore ".travis-*" | ||
sphinx-build -qnNW docs docs/_build/html | ||
docker-services-cli up ${DB} | ||
python setup.py test | ||
sphinx-build -qnNW -b doctest docs docs/_build/doctest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major: Missing the docker-services-cli down
see https://github.com/inveniosoftware/cookiecutter-invenio-module/blob/e3ca55f18a3e35ed4d3f5875d9647d408c45295b/%7B%7B%20cookiecutter.project_shortname%20%7D%7D/run-tests.sh#L12-L14
closes #219