global: migrate CI to GH Actions #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthS007
force-pushed
the
gh-actions
branch
2 times, most recently
from
6547d3e to
f005ba1
Compare
diegodelemos
reviewed
Dec 1, 2020
.github/workflows/tests.yml
Outdated
| env: | ||
| SQLALCHEMY_DATABASE_URI: ${{matrix.SQLALCHEMY_DATABASE_URI}} | ||
| POSTGRESQL_VERSION: ${{matrix.POSTGRESQL_VERSION}} | ||
| MYSQL_VERSION: ${{matrix.MYSQL_VERSION}} |
There was a problem hiding this comment.
Moderate: If we do not test mysql we do not need to set this env variable.
diegodelemos
reviewed
Dec 1, 2020
| set -o nounset | ||
|
|
||
| pydocstyle invenio_records_ui tests docs | ||
| isort invenio_records_ui tests --check-only --diff |
There was a problem hiding this comment.
Major: Same as inveniosoftware/invenio-oauth2server#220 (comment), missing docker-services-cli.
Closed
diegodelemos
reviewed
Dec 1, 2020
| isort invenio_records_ui tests --check-only --diff | ||
| check-manifest | ||
| sphinx-build -qnNW docs docs/_build/html | ||
| docker-services-cli up ${DB} | ||
| python setup.py test |
There was a problem hiding this comment.
Major: Missing the docker-services-cli down see https://github.com/inveniosoftware/cookiecutter-invenio-module/blob/e3ca55f18a3e35ed4d3f5875d9647d408c45295b/%7B%7B%20cookiecutter.project_shortname%20%7D%7D/run-tests.sh#L12-L14
diegodelemos
approved these changes
Dec 1, 2020
ParthS007
force-pushed
the
gh-actions
branch
3 times, most recently
from
f19cdd0 to
f82b1dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #93