Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: meta: add missing HighWire authors #2935

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: meta: add missing HighWire authors #2935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/details/meta.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{#
Copyright (C) 2020 CERN.
Copyright (C) 2020-2024 CERN.
Copyright (C) 2020 Northwestern University.
Copyright (C) 2021 New York University.
Copyright (C) 2023 Front Matter.
Expand All @@ -12,7 +12,7 @@

{%- set meta_title = record.metadata.title|striptags -%}
{%- set meta_description = record.metadata.description|striptags -%}
{%- set meta_authors = record.creators|map(attribute='name') -%}
{%- set meta_authors = record.metadata.creators|map(attribute='person_or_org')|map(attribute='name') -%}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we filter out organizations, or is it fine to include both people and organizations?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, I couldn't find anything about specifically marking orgs vs. people and orgs like "Project X Collaboration" still sounds valid.

{%- set files = record.files %}

{{- meta_highwire(meta_title,meta_description,authors=meta_authors,publisher=meta_publisher,publication_date=record.publication_date|from_isodate,doi=record.pids.get("doi", {}).get("identifier"),keywords=record.metadata.subjects | map(attribute="subject"),url=record.links.self_html) }}
Expand Down