fix: meta: add missing HighWire authors #2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptamarit
commented
Dec 9, 2024
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| {%- set meta_title = record.metadata.title|striptags -%} | |||
| {%- set meta_description = record.metadata.description|striptags -%} | |||
| {%- set meta_authors = record.creators|map(attribute='name') -%} | |||
| {%- set meta_authors = record.metadata.creators|map(attribute='person_or_org')|map(attribute='name') -%} | |||
There was a problem hiding this comment.
Should we filter out organizations, or is it fine to include both people and organizations?
There was a problem hiding this comment.
I think it's fine, I couldn't find anything about specifically marking orgs vs. people and orgs like "Project X Collaboration" still sounds valid.
ptamarit
force-pushed
the
fix-meta-highwire-authors-missing
branch
from
6d9689a to
323f0cb
Compare
ptamarit
changed the title
slint
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❤️ Thank you for your contribution!
Description
Landing pages never have a
<meta name="citation_author" content="..." />because the way of extracting the creators is not valid.This pull request fixes this.
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Frontend
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: