Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XeGPUToVC] Fix 'offset' computation for 'base address + offset' calc… #992

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

silee2
Copy link
Contributor

@silee2 silee2 commented Dec 23, 2024

…ulation

Current implementation of computing 'offset' fails for sub-byte types. This patch generalizes the implementation of 'offset' computation so that it works even for sub-byte types.

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

…ulation

Current implementation of computing 'offset' fails for sub-byte types.
This patch generalizes the implementation of 'offset' computation so that it works
even for sub-byte types.
@silee2 silee2 requested a review from Garra1980 December 23, 2024 18:26
@silee2 silee2 merged commit de3e322 into main Dec 23, 2024
2 checks passed
@silee2 silee2 deleted the fix-calc-num-bytes-main_for_upstream branch December 23, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants