Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TransposeOptimize] Fix a bug visitCreateNdDescOp. #983

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

chencha3
Copy link
Contributor

Fix a bug visitCreateNdDescOp which mistakenly treated CreateNdDesc is used twice because of user of UpdateNdOffset is also check in the chain, leading load+transpose+vnni in some cases are not folded.

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

used twice because of user of UpdateNdOffset is also check in the chain.
@chencha3 chencha3 merged commit 2bd7407 into main Dec 14, 2024
2 checks passed
@chencha3 chencha3 deleted the fix-transpose-optimize_for_upstream branch December 14, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants