[Region] Bufferize with one-shot-bufferize #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silee2
approved these changes
Dec 5, 2024
chencha3
approved these changes
Dec 9, 2024
fschlimb
reviewed
Dec 11, 2024
Comment on lines
84
to
87
| if (noTensorsIn(envOp.getArgs()) && noTensorsIn(envOp.getResults())) { | ||
| // Nothing to do. | ||
| return ::mlir::success(); | ||
| } |
There was a problem hiding this comment.
Is this needed? the docs say
This method will never be called on ops that do not have at least one
tensor operand/result.
There was a problem hiding this comment.
Agreed, this is not needed.
fschlimb
reviewed
Dec 11, 2024
| bool bufferizesToMemoryRead( | ||
| ::mlir::Operation *op, ::mlir::OpOperand &opOperand, | ||
| const ::mlir::bufferization::AnalysisState &state) const { | ||
| return true; |
There was a problem hiding this comment.
This implementation follows scf.yield op bufferization: read is true, write is false etc.
tkarna
force-pushed
the
region-dialect-one-shot-upstream
branch
from
48fd9b8 to
e4bdcbb
Compare
fschlimb
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review these guidelines to help with the review process: