Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XeTileToXeGPU] Add generic lowering pattern for Xetile elementwise o… #970

Merged

Conversation

mshahneo
Copy link
Contributor

…ps (arith, math dialect ops).

Allows Arith/math dialect pre/post-ops to be decomposed (blocked and updated).

Add a generic element-wise conversion pattern that can tackle all operations. It removes multiple patterns necessary to handle different kind of ops. It also supports passing attributes (e.g., fastmath).

Add support for all the operations in Arith dialect.

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

…ps (arith, math dialect ops).

Allows Arith/math dialect pre/post-ops to be decomposed (blocked and updated).

Add a generic element-wise conversion pattern that can tackle all operations.
It removes multiple patterns necessary to handle different kind of ops.
It also supports passing attributes (e.g., fastmath).

Add support for all the operations in Arith dialect.
@mshahneo mshahneo requested review from nbpatel and chencha3 November 25, 2024 17:19
Copy link
Contributor

@nbpatel nbpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshahneo mshahneo merged commit fd7fdc2 into intel:main Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants