fix(pipeline-run,model-run): clarify actors in Run objects #519
+192
−105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvallesm
requested review from
donch1989,
heiruwu,
pinglin and
xiaofei-du
as code owners
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
jvallesm
commented
Nov 20, 2024
| string model_uid = 2 [(google.api.field_behavior) = OUTPUT_ONLY]; | ||
| // 2 is reserved for the model UUID. Public resources should be identified by | ||
| // their ID and parent resource. | ||
| reserved 2; |
There was a problem hiding this comment.
-
modelUid -
pipelineUid -
namespaceId
jvallesm
force-pushed
the
jvalles/run-object-improvements
branch
from
9925a77
to
1442db5
Compare
triggered by commit: 23ffa9a
jvallesm
force-pushed
the
jvalles/run-object-improvements
branch
from
3937af7
to
c710e69
Compare
triggered by commit: b93adcb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
PipelineRunandModelRunobjects have confusing documentation forthe requester, runner and owner of a pipeline/model run.
This commit