fix: remove unused header from run by requester lists

instill-ai · Nov 22, 2024 · c710e69 · c710e69
1 parent 083402f
commit c710e69
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 18 deletions.
diff --git a/model/model/v1alpha/model_public_service.proto b/model/model/v1alpha/model_public_service.proto
@@ -852,8 +852,9 @@ service ModelPublicService {
   //
   // Returns a paginated list of runs for a given model. When the requester is
   // the owner of the model, they will be able to all the model runs,
-  // regardless who requested the trigger. Other requesters will only be able
-  // to see the runs requested by themselves.
+  // regardless who requested the trigger (the view will be partial to hide
+  // sensitive data like e.g. the trigger input and output). Other requesters
+  // will only be able to see the runs requested by themselves.
   rpc ListModelRuns(ListModelRunsRequest) returns (ListModelRunsResponse) {
     option (google.api.http) = {get: "/v1alpha/namespaces/{namespace_id}/models/{model_id}/runs"};
     option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
@@ -880,13 +881,6 @@ service ModelPublicService {
     option (google.api.http) = {get: "/v1alpha/dashboard/models/runs"};
     option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
       tags: "⚗️ Model"
-      parameters: {
-        headers: {
-          name: "Instill-Requester-Uid"
-          description: "Indicates the authenticated namespace is making the request on behalf of another entity, typically an organization they belong to"
-          type: STRING
-        }
-      }
       extensions: {
         key: "x-stage"
         value: {string_value: "alpha"}

diff --git a/vdp/pipeline/v1beta/pipeline_public_service.proto b/vdp/pipeline/v1beta/pipeline_public_service.proto
@@ -1342,8 +1342,9 @@ service PipelinePublicService {
   //
   // Returns a paginated list of runs for a given pipeline. When the requester
   // is the owner of the pipeline, they will be able to all the pipeline runs,
-  // regardless who requested the trigger. Other requesters will only be able
-  // to see the runs requested by themselves.
+  // regardless who requested the trigger (the view will be partial to hide
+  // sensitive data like e.g. the trigger input and output). Other requesters
+  // will only be able to see the runs requested by themselves.
   rpc ListPipelineRuns(ListPipelineRunsRequest) returns (ListPipelineRunsResponse) {
     option (google.api.http) = {get: "/v1beta/namespaces/{namespace_id}/pipelines/{pipeline_id}/runs"};
     option (grpc.gateway.protoc_gen_openapiv2.options.openapiv2_operation) = {
@@ -1395,13 +1396,6 @@ service PipelinePublicService {
         key: "x-stage"
         value: {string_value: "beta"}
       }
-      parameters: {
-        headers: {
-          name: "Instill-Requester-Uid"
-          description: "Indicates the authenticated namespace is making the request on behalf of another entity, typically an organization they belong to"
-          type: STRING
-        }
-      }
     };
   }