Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate feasibility of exclusively using ggplot2 for all plots #1109

Closed
1 of 2 tasks
edelarua opened this issue Oct 26, 2023 · 3 comments
Closed
1 of 2 tasks

Investigate feasibility of exclusively using ggplot2 for all plots #1109

edelarua opened this issue Oct 26, 2023 · 3 comments
Assignees
@edelarua
Labels
enhancement research sme

Comments

@edelarua
Copy link
Contributor

edelarua commented Oct 26, 2023 •
edited
Loading

Currently all but two plotting functions exclusively use ggplot2. These two functions were implemented using grobs to avoid issues when combining plots with accompanying annotation tables.

Look into feasibility of converting the following functions to use only ggplot2 (i.e. geom_text) instead of grobs:
@edelarua
Copy link
Contributor Author

Another option for forest plots: https://github.com/insightsengineering/sme-tasks/issues/433

@edelarua edelarua self-assigned this Nov 17, 2023
@edelarua edelarua mentioned this issue Dec 8, 2023
Merged
@edelarua
Copy link
Contributor Author

edelarua commented Dec 14, 2023 •
edited
Loading

g_forest:

shajoezhu pushed a commit that referenced this issue Dec 20, 2023
@edelarua @walkowif @github-actions
Refactor g_forest (#1158)
ccbc10c 
# Pull Request

<!--- Replace `#nnn` with your issue link for reference. -->

Part of #1109

`g_forest` creates a `ggplot` object instead of a `grob` object.

---------

Co-authored-by: walkowif <[email protected]>
Co-authored-by: walkowif <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@shajoezhu shajoezhu mentioned this issue Jan 5, 2024
Closed
@shajoezhu
Copy link
Contributor

Hi @edelarua , I have created a new issue to follow up on the g_km part, I think we can close this one for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edelarua edelarua

Labels
enhancement research sme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shajoezhu @edelarua