Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate feasibility of exclusively using ggplot2 for all plots - part II (g_km) #1167

Closed
shajoezhu opened this issue Jan 5, 2024 · 3 comments · Fixed by #1210
Closed
Assignees

Comments

@shajoezhu
Copy link
Contributor

See original issue #1109

Currently all but two plotting functions exclusively use ggplot2. These two functions were implemented using grobs to avoid issues when combining plots with accompanying annotation tables.

Look into feasibility of converting the following functions to use only ggplot2 (i.e. geom_text) instead of grobs:

@shajoezhu shajoezhu added the sme label Jan 5, 2024
@edelarua edelarua self-assigned this Jan 5, 2024
@Melkiades
Copy link
Contributor

Is this still in progress?

@shajoezhu
Copy link
Contributor Author

hi @edelarua , was wondering how we doing on this?

@Teninq , is there anything else that you would like to request regarding this feature?

@edelarua
Copy link
Contributor

edelarua commented Mar 12, 2024

I am still working on this! I can focus on finishing it up this week since I’m probably about halfway done.

edelarua added a commit that referenced this issue Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants