Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve todos #1410

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Resolve todos #1410

merged 11 commits into from
Nov 22, 2024

Conversation

gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Nov 13, 2024

closes #1312
One commit for one todo. Each commit contains a comment about a taken action

@gogonzo gogonzo changed the title 1312 todos Resolve todos Nov 13, 2024
@gogonzo gogonzo added the core label Nov 13, 2024
@m7pr
Copy link
Contributor

m7pr commented Nov 14, 2024

Sending an empty commit to restart builds on this branch

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Unit Tests Summary

  1 files   25 suites   9m 10s ⏱️
268 tests 264 ✅ 4 💤 0 ❌
523 runs  519 ✅ 4 💤 0 ❌

Results for commit a738d20.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-data_summary 💔 $51.19$ $+1.95$ $0$ $0$ $0$ $0$
shinytest2-filter_panel 💔 $42.26$ $+1.45$ $0$ $0$ $0$ $0$
shinytest2-reporter 💔 $67.53$ $+1.50$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
rcode_utils 💀 $0.01$ $-0.01$ get_datasets_code_returns_code_only_for_specified_datanames

Results for commit ac7f44d

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ----------------------------------------------------------------------------------------------------------------------------------------
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  47      11  76.60%   27, 29, 41, 52-59
R/get_rcode_utils.R                  12       0  100.00%
R/include_css_js.R                   22      17  22.73%   12-38, 76-82
R/init.R                             99      42  57.58%   150-159, 161, 173-194, 219-222, 229-235, 238-239, 241
R/landing_popup_module.R             25      25  0.00%    61-87
R/module_bookmark_manager.R         158     127  19.62%   47-68, 88-138, 143-144, 156, 203, 238-315
R/module_data_summary.R             203      37  81.77%   26-54, 68, 78, 232, 263-267
R/module_filter_data.R               64       2  96.88%   22-23
R/module_filter_manager.R           230      57  75.22%   56-62, 73-82, 90-95, 108-112, 117-118, 291-314, 340, 367, 379, 386-387
R/module_init_data.R                 74       0  100.00%
R/module_nested_tabs.R              234      91  61.11%   40-142, 174, 199-201, 320, 352
R/module_snapshot_manager.R         216     146  32.41%   89-95, 104-113, 121-133, 152-153, 170-180, 184-199, 201-208, 215-230, 234-238, 240-246, 249-262, 265-273, 303-317, 320-331, 334-340, 354
R/module_teal_data.R                149      10  93.29%   41-48, 84, 135-136
R/module_teal_lockfile.R            131      44  66.41%   32-36, 44-56, 59-61, 75, 85-87, 99-101, 109-118, 121, 123, 125-126, 160-161
R/module_teal_with_splash.R          12      12  0.00%    22-38
R/module_teal.R                     190      87  54.21%   48-143, 158, 184-185, 216
R/module_transform_data.R            54      32  40.74%   17-52
R/modules.R                         280      72  74.29%   173-177, 232-235, 356-376, 384, 534-540, 553-562, 578-626, 659, 671-679
R/reporter_previewer_module.R        19       2  89.47%   30, 34
R/show_rcode_modal.R                 24      24  0.00%    17-42
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       24       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 58       0  100.00%
R/teal_data_utils.R                  10       0  100.00%
R/teal_reporter.R                    68       6  91.18%   69, 77, 125-126, 129, 146
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/TealAppDriver.R                   353     353  0.00%    52-735
R/utils.R                           253      38  84.98%   405-454
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   110-377
R/zzz.R                              15      11  26.67%   4-18
TOTAL                              3251    1297  60.10%

Diff against main

Filename                  Stmts    Miss  Cover
----------------------  -------  ------  -------
R/module_nested_tabs.R       -2       0  -0.33%
TOTAL                        -2       0  -0.02%

Results for commit: a738d20

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@llrs-roche llrs-roche self-assigned this Nov 19, 2024
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
How do you generate graphs like the ones on #1408 ?

@gogonzo
Copy link
Contributor Author

gogonzo commented Nov 19, 2024

How do you generate graphs like the ones on #1408 ?

WIth draw.io for example. It is integrated in google drive. Go to drive.google.com > click new button (top left corner) > more > draw.io

Merge commit '8c143f108778c5a03364747d5f6b6aaac5a252d7'

#Conflicts:
#	tests/testthat/test-module_teal.R
@llrs-roche llrs-roche enabled auto-merge (squash) November 22, 2024 16:14
@llrs-roche llrs-roche merged commit 161e480 into main Nov 22, 2024
24 checks passed
@llrs-roche llrs-roche deleted the 1312_todos branch November 22, 2024 16:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve all "TODO:" in the codebase
3 participants