Resolve todos (#1410)

Co-authored-by: m7pr <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Marcin <[email protected]>
Co-authored-by: Lluís Revilla <[email protected]>

R/module_data_summary.R

@@ -157,12 +157,6 @@ get_filter_overview_wrapper <- function(teal_data) {
     datanames,
     function(dataname) {
       parent <- teal.data::parent(joinkeys, dataname)
-      # todo: what should we display for a parent dataset?
-      #     - Obs and Subjects
-      #     - Obs only
-      #     - Subjects only
-      # todo (for later): summary table should be displayed in a way that child datasets
-      #       are indented under their parent dataset to form a tree structure
       subject_keys <- if (length(parent) > 0) {
         names(joinkeys[dataname, parent])
       } else {

R/module_filter_manager.R

@@ -388,4 +388,3 @@ methods::setOldClass("reactivevalues")
     }
   )
 )
-# todo: prevent any teal_slices attribute except mapping

R/module_nested_tabs.R

@@ -319,14 +319,6 @@ srv_teal_module.teal_module <- function(id,
         # When previewer is delayed, cards are bookmarked only if previewer has been initiated (visited).
         module_out(.call_teal_module(modules, datasets, module_teal_data, reporter))
       }
-
-      # todo: (feature request) add a ReporterCard to the reporter as an output from the teal_module
-      #       how to determine if module returns a ReporterCard so that reportPreviewer is needed?
-      #       Should we insertUI of the ReportPreviewer then?
-      #       What about attr(module, "reportable") - similar to attr(module, "bookmarkable")
-      if ("report" %in% names(module_out)) {
-        # (reactively) add card to the reporter
-      }
     })
 
     module_out

R/module_snapshot_manager.R

@@ -283,7 +283,6 @@ srv_snapshot_manager <- function(id, slices_global) {
       s <- "Initial application state"
       ### Begin restore procedure. ###
       snapshot <- snapshot_history()[[s]]
-      # todo: as.teal_slices looses module-mapping if is not global
       snapshot_state <- as.teal_slices(snapshot)
       slices_global$slices_set(snapshot_state)
       removeModal()

R/module_teal.R

@@ -210,7 +210,6 @@ srv_teal <- function(id, data, modules, filter = teal_slices()) {
     data_load_status <- reactive({
       if (inherits(data_pulled(), "teal_data")) {
         "ok"
-        # todo: should we hide warnings on top for a data?
       } else if (inherits(data, "teal_data_module")) {
         "teal_data_module failed"
       } else {

R/module_transform_data.R

@@ -27,7 +27,7 @@ ui_transform_data <- function(id, transformers = list(), class = "well") {
     function(name) {
       data_mod <- transformers[[name]]
       wrapper_id <- ns(sprintf("wrapper_%s", name))
-      div( # todo: accordion?
+      div(
         # class .teal_validated changes the color of the boarder on error in ui_validate_reactive_teal_data
         #   For details see tealValidate.js file.
         class = c(class, "teal_validated"),

tests/testthat/test-rcode_utils.R

@@ -47,14 +47,3 @@ testthat::test_that("get_rcode_libraries returns current session packages", {
     )
   )
 })
-
-testthat::test_that("get_datasets_code returns code only for specified datanames", {
-  # todo: need to use code dependency? Or test it later via public functions/modules
-  datasets <- teal.slice::init_filtered_data(
-    list(
-      IRIS = iris,
-      MTCARS = mtcars
-    )
-  )
-  testthat::expect_true(TRUE)
-})