Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review teal.transform documentation before release #125

Closed
donyunardi opened this issue Mar 24, 2023 · 2 comments · Fixed by #130
Closed

Review teal.transform documentation before release #125

donyunardi opened this issue Mar 24, 2023 · 2 comments · Fixed by #130
Assignees
@asbates
Labels
core

Comments

@donyunardi
Copy link
Contributor

donyunardi commented Mar 24, 2023 •
edited
Loading

Summary

Related with insightsengineering/nestdevs-tasks#13
In preparation to release, we need to review/assess all documentation in the package.

Acceptance Criteria

  • Review roxygen examples on all functions
    • Test examples
    • If it's using chunk, update to qenv.
  • Review vignettes on these topics only:
    • Review any content around qenv
    • Review any content around chunks (i.e. make sure the right language around deprecation)
    • Review any content around shinyvalidate
  • Update NEWS
  • Update README (if applicable)
  • Review DESCRIPTION file (i.e. dependency versions, etc)
@donyunardi donyunardi mentioned this issue Mar 24, 2023
Closed
@asbates asbates self-assigned this Apr 5, 2023
@asbates
Copy link
Contributor

asbates commented Apr 6, 2023 •
edited
Loading

@asbates asbates mentioned this issue Apr 11, 2023
Closed
@asbates
Copy link
Contributor

asbates commented Apr 13, 2023

status: all examples have been checked and/or fixed.

@asbates asbates mentioned this issue Apr 14, 2023
Merged
asbates added a commit that referenced this issue Apr 17, 2023
@asbates @dependabot-preview
Update docs (#130)
801b461 
Updates some documentation in preparation for release. These changes
regard examples in the roxygen docs.

There are still a few more documentation changes to be made. However
they are beyond what I can do quickly so I opened #128.

Also note there is still some chunks usage. I've opened #129 to address
this.

Fixes #125

---------

Co-authored-by: 27856297+dependabot-preview[bot]@users.noreply.github.com <27856297+dependabot-preview[bot]@users.noreply.github.com>
@donyunardi donyunardi mentioned this issue May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asbates asbates

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update docs insightsengineering/teal.transform
2 participants
@donyunardi @asbates