Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release teal and modules in GitHub #13

Closed
Tracked by #85
donyunardi opened this issue Mar 22, 2023 · 7 comments
Closed
Tracked by #85

Release teal and modules in GitHub #13

donyunardi opened this issue Mar 22, 2023 · 7 comments
Labels

Comments

@donyunardi
Copy link
Collaborator

donyunardi commented Mar 22, 2023

Summary

This is continuation of insightsengineering/teal.code#100

A new feature called qenv is being introduced with the release of teal.code.
We also implement the changes to the teal modules and framework here and here.

We are ready to release the rest of teal packages.

Important

Since we're releasing the modules as well, then we also have to release any affected packages that's related with shinyvalidate tasks here

Packages to be released

  • teal
  • teal.widgets
  • teal.slice
  • teal.transform
  • teal.data
  • tmg
  • tmc (check if tern is good to go)
  • goshawk + teal.goshawk
  • osprey + teal.osprey
  • hermes + tmhermes
  • helios + tmhelios

Order of releases

  1. teal, teal.widgets, teal.slice, teal.transform, teal.data
  2. tmg + tmhermes + hermes (?)
  3. tmc
  4. goshawk + teal.goshawk
  5. osprey + teal.osprey
  6. helios + tmhelios

Tasks

@asbates
Copy link

asbates commented Mar 24, 2023

Releasing teal.goshawk and teal.osprey requires release of goshawk and osprey I believe. Likewise with tmhelios I presume.

Regarding testing of teal.gallery apps, I don't think that will be sufficient? I would recommend going through and making sure any packages that are to be released are used in teal.gallery. tmhelios probably isn't for example.

@asbates
Copy link

asbates commented Mar 24, 2023

I also recommend removing anything deprecated (e.g. chunks). I think it would be confusing for users if they install a new CRAN package and it has deprecation warnings.

@donyunardi
Copy link
Collaborator Author

Releasing teal.goshawk and teal.osprey requires release of goshawk and osprey I believe. Likewise with tmhelios I presume.

That's a valid point, and most likely true for helios. As for goshawk and osprey, I don't see if there's any impact if we don't release them. I could be wrong and could use another set of eyes. Regardless, I will add it to our plan.


Regarding testing of teal.gallery apps, I don't think that will be sufficient? I would recommend going through and making sure any packages that are to be released are used in teal.gallery. tmhelios probably isn't for example.

We're just conducting a quick check to ensure that everything is functioning properly, given that we have a URL that's accessible to the public. We're currently reconsidering how we can enhance teal.gallery, so it might be best to hold off on including tmhelios in the list of sample applications for the time being.


I also recommend removing anything deprecated (e.g. chunks). I think it would be confusing for users if they install a new CRAN package and it has deprecation warnings.

Upon inspection, I see that we're still using chunks in teal.transform:
https://github.com/insightsengineering/teal.transform/blob/c07e7505b9c9b0222a2e933382f90381afdfd1b1/R/data_merge_module.R#L267-L276

We probably need to update this first before completely removing chunks from teal.code.
Once everything is taken care of, we can release teal.code again and remove chunks completely.
I will add a generic topic on the CRAN release card to remove all soft-deprecated functions.

@asbates
Copy link

asbates commented Mar 27, 2023

Releasing teal.goshawk and teal.osprey requires release of goshawk and osprey I believe. Likewise with tmhelios I presume.

That's a valid point, and most likely true for helios. As for goshawk and osprey, I don't see if there's any impact if we don't release them. I could be wrong and could use another set of eyes. Regardless, I will add it to our plan.

teal.goshawk depends on goshawk and teal.osprey depends on osprey. So I don't see why we would release the teal packages but not the packages they depend on. I'm not even sure if CRAN allows that.

@donyunardi
Copy link
Collaborator Author

Because of these two PRs that affects update in both teal.data and teal.slice, we need to release teal.data as well:
insightsengineering/teal.data#120
insightsengineering/teal.slice#169

I will include teal.data in Release 1.

@donyunardi
Copy link
Collaborator Author

Due to my finding here: https://github.com/insightsengineering/idr-tasks/issues/540#issuecomment-1553992381
We have to release tmhermes after release 1.
OP updated.

@donyunardi donyunardi changed the title Release teal and modules in GitHub Release teal and modules in GitHub (Part 1) May 23, 2023
@donyunardi donyunardi changed the title Release teal and modules in GitHub (Part 1) Release teal and modules in GitHub May 23, 2023
@donyunardi
Copy link
Collaborator Author

Release 1 is completed.
We will move with teal modules in #25 for the next increment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants