Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #130

Merged
merged 7 commits into from
Apr 17, 2023
Merged

Update docs #130

merged 7 commits into from
Apr 17, 2023

Conversation

asbates
Copy link
Contributor

@asbates asbates commented Apr 14, 2023

Updates some documentation in preparation for release. These changes regard examples in the roxygen docs.

There are still a few more documentation changes to be made. However they are beyond what I can do quickly so I opened #128.

Also note there is still some chunks usage. I've opened #129 to address this.

Fixes #125

@asbates asbates added the core label Apr 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  ------------------------------------------------------------------------
R/all_choices.R                       1       0  100.00%
R/call_utils.R                      156     124  20.51%   14-23, 64, 66, 68, 107-431
R/check_selector.R                   31       0  100.00%
R/choices_labeled.R                 200      61  69.50%   60, 66, 71, 78, 94, 218-222, 226-231, 261-274, 388-389, 391, 423-471
R/choices_selected.R                 81      11  86.42%   201-229, 260
R/column_functions.R                  3       3  0.00%    13-16
R/data_extract_datanames.R           32       8  75.00%   9-13, 64-66
R/data_extract_filter_module.R       95      16  83.16%   75-88, 90-91, 145
R/data_extract_module.R             298      66  77.85%   3, 115, 120, 137, 140-145, 147, 166-169, 197-243, 477, 482, 661, 727-732
R/data_extract_read_module.R        135       7  94.81%   29, 33-36, 131, 148
R/data_extract_select_module.R       32      18  43.75%   31-48
R/data_extract_single_module.R       53       2  96.23%   29, 42
R/data_extract_spec.R                32       0  100.00%
R/data_merge_module.R                61      15  75.41%   101-118
R/filter_spec.R                     186       1  99.46%   303
R/format_data_extract.R              16       1  93.75%   49
R/get_dplyr_call.R                  299       0  100.00%
R/get_merge_call.R                  280      29  89.64%   28-34, 45, 206-215, 369, 385-397
R/include_css_js.R                    5       0  100.00%
R/input_checks.R                     11       2  81.82%   18-19
R/merge_data_utils.R                  2       0  100.00%
R/merge_datasets.R                  135       6  95.56%   77, 225-229
R/merge_expression_module.R          49       1  97.96%   147
R/Queue.R                            23       0  100.00%
R/resolve_delayed.R                  16       0  100.00%
R/resolve.R                         114      44  61.40%   229-312
R/select_spec.R                      49       8  83.67%   103, 167-174
R/utils.R                            24      11  54.17%   26-39
R/zzz.R                               2       2  0.00%    2-3
TOTAL                              2421     436  81.99%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 124b158

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

Unit Tests Summary

    1 files    25 suites   36s ⏱️
208 tests 207 ✔️ 1 💤 0
728 runs  727 ✔️ 1 💤 0

Results for commit fe0218f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@donyunardi donyunardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asbates
Copy link
Contributor Author

asbates commented Apr 17, 2023

@donyunardi I'm not sure why R CMD check still hasn't run. Is there a way to force it to run?

@donyunardi
Copy link
Contributor

@walkowif @cicdguy Can we force run the workflow?

@cicdguy
Copy link
Contributor

cicdguy commented Apr 17, 2023

@walkowif @cicdguy Can we force run the workflow?

Just push an empty commit to retrigger the workflows

@cicdguy
Copy link
Contributor

cicdguy commented Apr 17, 2023

The bot doesn't run workflows on auto-updates to prevent recursive workflow runs

@asbates asbates merged commit 801b461 into main Apr 17, 2023
@asbates asbates deleted the 125_docs@main branch April 17, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review teal.transform documentation before release
3 participants