-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new regexp to the r-cmd-check-note blocklist #291
base: main
Are you sure you want to change the base?
Conversation
Code Coverage Summary
Diff against main
Results for commit: 5bd4f88 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 18 suites 27s ⏱️ Results for commit 5bd4f88. ♻️ This comment has been updated with latest results. |
Signed-off-by: Lluís Revilla <[email protected]>
Hi @insightsengineering/idr I provided this PR to check on all packages the vignettes issues, is this the way to go? If this is the way I'll provide another one on a different PR for "Please provide package anchors for all Rd \link{} targets not in the package itself and the base packages." which was recently observed in different packages, for example in insightsengineering/teal.modules.general#813 |
This PR is to add the notes to the CI part per #288 but only for teal.reporter.
The changes do not look to the general issue as vignettes failing to build could be due to a number of reasons. As far as I know the string I added is specific for this error. To fix the issue PR #290 was already merge so I don't expect any failures now.
This could be added to the default/general check from r.pkg.template if it meets the IDR requirements.