Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R CMD CHECK note #288

Closed
1 of 2 tasks
pawelru opened this issue Sep 30, 2024 · 3 comments · Fixed by #290 · May be fixed by #291
Closed
1 of 2 tasks

R CMD CHECK note #288

pawelru opened this issue Sep 30, 2024 · 3 comments · Fixed by #290 · May be fixed by #291

Comments

@pawelru
Copy link
Contributor

pawelru commented Sep 30, 2024

* checking files in ‘vignettes’ ... NOTE
Files named as vignettes but with no recognized vignette engine:
   ‘vignettes/_setup.Rmd’
(Is a VignetteBuilder field missing?)
@pawelru pawelru linked a pull request Nov 27, 2024 that will close this issue
@pawelru
Copy link
Contributor Author

pawelru commented Nov 27, 2024

Hey @llrs-roche, I have linked your PR as this essentially solves the issue but can you also have a look at the CI part so that it would be automatically captured by CI on commit (instead of external testing service)

@llrs-roche
Copy link
Contributor

Oh, I didn't realize there was already an issue for this.
The list on the blocklist seems to only use the official R message, not the specific note/warning/error (if any(. I'll try to see if it is possible to capture that.

@pawelru
Copy link
Contributor Author

pawelru commented Nov 27, 2024

That list is collapsed into one string with | and then there is a simple regular expression on the R CMD CHECK output. It means that we just need to extend it with yet another element against that use case.
The good/bad thing about this is that that list is defined for each repo. It's good because it allows for exceptions. It's bad because if we want to extend the list for all pkgs then it means a lot of PRs. I know IDR team has some magic tool that does such propagation - in such case let's create a task and explain in detail what and where. They are doing this periodically when number of requests reach some threshold (whatever it is). But it's important to note it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants