-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vignette note #290
Remove vignette note #290
Conversation
✅ All contributors have signed the CLA |
I have read the CLA Document and I hereby sign the CLA |
Code Coverage Summary
Diff against main
Results for commit: 2deef3c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 18 suites 26s ⏱️ Results for commit 2deef3c. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
Pull Request
CI checks are failing due to the vignettes not being created.
There is a note about using a Rmd as childe file in the vignettes. This file is recognized as a vignette.
We can a) move it to a different folder like what it is done for articles, something like
vignettes/child
? or b) move the code chunk into the vignette.As it was only used once, I moved the code chunk into the file directly.
This made this error disappear.
There were errors due to some code moving from rtables to rtables.office. I think this should be taken care now that rtables.office is fixed and building well.