Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vignette note #290

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Remove vignette note #290

merged 1 commit into from
Nov 27, 2024

Conversation

llrs-roche
Copy link
Contributor

Pull Request

CI checks are failing due to the vignettes not being created.

There is a note about using a Rmd as childe file in the vignettes. This file is recognized as a vignette.
We can a) move it to a different folder like what it is done for articles, something like vignettes/child? or b) move the code chunk into the vignette.
As it was only used once, I moved the code chunk into the file directly.
This made this error disappear.

There were errors due to some code moving from rtables to rtables.office. I think this should be taken care now that rtables.office is fixed and building well.

Copy link
Contributor

github-actions bot commented Nov 26, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@llrs-roche
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

badge

Code Coverage Summary

Filename                  Stmts    Miss  Cover    Missing
----------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------
R/AddCardModule.R           146       2  98.63%   170, 207
R/ContentBlock.R             18       2  88.89%   57-63
R/DownloadModule.R          238      67  71.85%   98-104, 152, 183-188, 197-202, 205-210, 219-224, 227-232, 240-245, 248-253, 260-265, 268-273, 312-316
R/FileBlock.R                13       0  100.00%
R/LoadReporterModule.R      103      19  81.55%   100-105, 108-113, 119-124, 136
R/NewpageBlock.R              2       0  100.00%
R/PictureBlock.R             30       2  93.33%   20, 118
R/Previewer.R               372      95  74.46%   96-98, 101-102, 184-213, 217-219, 222, 289, 304, 306-309, 312, 315-323, 437-481
R/RcodeBlock.R               15       0  100.00%
R/Renderer.R                113      37  67.26%   97-112, 216, 224, 233, 235-256
R/ReportCard.R               84       3  96.43%   239, 244, 269
R/Reporter.R                107       6  94.39%   273-278
R/ResetModule.R              53       0  100.00%
R/SimpleReporter.R           32       0  100.00%
R/TableBlock.R                9       0  100.00%
R/TextBlock.R                13       0  100.00%
R/utils.R                   126      86  31.75%   7, 38-97, 99, 102-109, 137, 161-169, 206-215
R/yaml_utils.R               81       2  97.53%   78, 289
R/zzz.R                      14      10  28.57%   2-13, 19
TOTAL                      1569     331  78.90%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 2deef3c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Unit Tests Summary

  1 files   18 suites   26s ⏱️
189 tests 189 ✅ 0 💤 0 ❌
329 runs  329 ✅ 0 💤 0 ❌

Results for commit 2deef3c.

♻️ This comment has been updated with latest results.

@pawelru pawelru linked an issue Nov 27, 2024 that may be closed by this pull request
2 tasks
Copy link
Contributor

@pawelru pawelru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@llrs-roche llrs-roche merged commit bf5e305 into main Nov 27, 2024
29 checks passed
@llrs-roche llrs-roche deleted the fix_vignette@main branch November 27, 2024 14:21
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R CMD CHECK note
2 participants