Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for heatmap #112

Closed
wants to merge 2 commits into from
Closed

add support for heatmap #112

wants to merge 2 commits into from

Conversation

mhallal1
Copy link
Contributor

@mhallal1 mhallal1 commented Jul 11, 2022

part of insightsengineering/teal.modules.hermes#238
Add support for Heatmap class in PictureBlock to support pca module tmh.

@mhallal1 mhallal1 added the core label Jul 11, 2022
@github-actions
Copy link
Contributor

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------
R/AddCardModule.R       100       3  97.00%   75-77
R/Archiver.R             25       0  100.00%
R/ContentBlock.R         16       0  100.00%
R/DownloadModule.R      161      40  75.16%   77-79, 100, 150-155, 164-168, 171-175, 183-187, 190-194, 201-205, 208-212
R/FileBlock.R            13       0  100.00%
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         30       1  96.67%   15
R/Previewer.R           217      11  94.93%   162, 164-167, 172-178
R/Renderer.R             54       4  92.59%   142, 144-145, 166
R/ReportCard.R           76       2  97.37%   211, 232
R/Reporter.R             96       1  98.96%   255
R/ResetModule.R          45       0  100.00%
R/SimpleReporter.R       18       0  100.00%
R/TableBlock.R            8       0  100.00%
R/TealReportCard.R       20       0  100.00%
R/TextBlock.R            13       0  100.00%
R/yaml_utils.R           74       2  97.30%   65, 263
TOTAL                   968      64  93.39%

Results for commit: 4171a6f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    17 suites   8s ⏱️
186 tests 186 ✔️ 0 💤 0
268 runs  268 ✔️ 0 💤 0

Results for commit 761a459.

@Polkas
Copy link
Contributor

Polkas commented Jul 11, 2022

Please add some tests for it, the needed package could be in Suggests.

Copy link
Contributor

@Polkas Polkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As ComplexHeatmap::Heatmap demands a Bioc dependency so I think we could skip it or artificially return an object of its type.

R/PictureBlock.R Outdated Show resolved Hide resolved
Co-authored-by: Dawid Kałędkowski <[email protected]>
@mhallal1
Copy link
Contributor Author

replaced by #113

@mhallal1 mhallal1 closed this Jul 11, 2022
@insights-engineering-bot insights-engineering-bot deleted the 238_add_heatmap@main branch July 2, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants