Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reporter #265

Merged
merged 12 commits into from
Jul 13, 2022
Merged

Add reporter #265

merged 12 commits into from
Jul 13, 2022

Conversation

mhallal1
Copy link
Collaborator

@mhallal1 mhallal1 commented Jul 11, 2022

closes #238

Add reporter to all modules including:

  1. plot/table
  2. all selected encodings
  3. filter panel

the PCA correlation plot depends on this PR: insightsengineering/teal.reporter#113

@mhallal1 mhallal1 added the core label Jul 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2022

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           157      11  92.99%   308-312, 358-362, 364
R/assaySpec.R            44      36  18.18%   102-142
R/barplot.R             170     132  22.35%   40-64, 127-257
R/boxplot.R             173     140  19.08%   41-65, 124-260
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       92      58  36.96%   99, 214-285
R/forestplot.R          201     171  14.93%   60-91, 151-315
R/geneSpec.R            255     136  46.67%   153-168, 297-448
R/km.R                  190     154  18.95%   63-92, 157-306
R/pca.R                 347     264  23.92%   35-55, 162-453
R/quality.R             299     224  25.08%   18-109, 207-430
R/sampleVarSpec.R       221     100  54.75%   296-302, 314-321, 323, 331-342, 344-345, 347, 350, 358-362, 364-379, 384-407, 410-414, 416, 423-433, 435-436, 444, 489-506
R/scatterplot.R         168     133  20.83%   40-64, 126-257
R/utils.R                16       5  68.75%   75-79
R/volcanoplot.R         195     160  17.95%   35-56, 115-280
R/zzz.R                   1       1  0.00%    2
TOTAL                  2547    1734  31.92%

Results for commit: 3712b0e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2022

Unit Tests Summary

  1 files  15 suites   25s ⏱️
58 tests 36 ✔️ 22 💤 0
85 runs  63 ✔️ 22 💤 0

Results for commit 38e085a.

♻️ This comment has been updated with latest results.

@Polkas Polkas self-assigned this Jul 11, 2022
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mhallal1 ! I did not try it out yet, but trust @Polkas that he will and give feedback on the user experience. One ask, can you please run the shiny tests manually with testing depth 5 and make sure they pass / make any adjustments as needed for the reporter to make them pass. Thanks a lot!

@Polkas
Copy link
Contributor

Polkas commented Jul 12, 2022

Modules combined teal.gallery::launch_app("RNA-seq")

Modules separately:

  • tm_g_barplot
  • tm_g_boxplot
  • tm_g_forest_tte
  • tm_g_km
  • tm_g_pca
  • tm_g_quality
  • tm_g_scatterplot
  • tm_g_volcanoplot

R/forestplot.R Outdated Show resolved Hide resolved
R/forestplot.R Outdated Show resolved Hide resolved
R/quality.R Outdated Show resolved Hide resolved
@Polkas
Copy link
Contributor

Polkas commented Jul 12, 2022

Please do not print the Encoding elements if they are optional and empty.
image

@Polkas
Copy link
Contributor

Polkas commented Jul 12, 2022

It is surprising that only one module is using plot_with_settings/table_with_settings.
#61

@Polkas
Copy link
Contributor

Polkas commented Jul 12, 2022

Please regenarate the _snaps directory in the testthat.
We have some Errors under the testing depth 5 nevertheless they are already on the main branch.

@mhallal1
Copy link
Collaborator Author

Please regenarate or remove the _snaps directory in the testthat. We have some Errors under the testing depth 5 nevertheless they are already on the main branch.

Issue created as it existed on main already: #266

@mhallal1
Copy link
Collaborator Author

@danielinteractive we had to update the snaps folder to pass the test with a depth of 5:
Screenshot from 2022-07-13 11-37-45

@mhallal1
Copy link
Collaborator Author

Please do not print the Encoding elements if they are optional and empty. image

fixed.

Copy link
Contributor

@Polkas Polkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work:)
Please create an issue for checking the plot with settings (empty returned height and width) in forest plot, thanks.

R/forestplot.R Outdated
style = "verbatim"
)
card$append_text("Plot", "header3")
card$append_plot(forest_plot())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
card$append_plot(forest_plot())
card$append_plot(forest_plot(), dim = pws$dim())

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue created: #267

@mhallal1 mhallal1 merged commit 82cc802 into main Jul 13, 2022
@mhallal1 mhallal1 deleted the 238_add_reporter@main branch July 13, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add teal.reporter into tmh modules
3 participants