-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reporter #265
Add reporter #265
Conversation
Code Coverage Summary
Results for commit: 3712b0e Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @mhallal1 ! I did not try it out yet, but trust @Polkas that he will and give feedback on the user experience. One ask, can you please run the shiny tests manually with testing depth 5 and make sure they pass / make any adjustments as needed for the reporter to make them pass. Thanks a lot!
Modules combined Modules separately:
|
It is surprising that only one module is using plot_with_settings/table_with_settings. |
Please regenarate the _snaps directory in the testthat. |
Issue created as it existed on main already: #266 |
Co-authored-by: Maciej Nasinski <[email protected]>
Co-authored-by: Maciej Nasinski <[email protected]>
@danielinteractive we had to update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work:)
Please create an issue for checking the plot with settings (empty returned height and width) in forest plot, thanks.
R/forestplot.R
Outdated
style = "verbatim" | ||
) | ||
card$append_text("Plot", "header3") | ||
card$append_plot(forest_plot()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
card$append_plot(forest_plot()) | |
card$append_plot(forest_plot(), dim = pws$dim()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue created: #267
closes #238
Add
reporter
to all modules including:the PCA correlation plot depends on this PR: insightsengineering/teal.reporter#113