26 new chunks@main #172
Merged
26 new chunks@main #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: cicdguy <[email protected]>
gogonzo
commented
Aug 16, 2022
|
|
||
| teal.code::chunks_reset(envir = environment()) | ||
|
|
||
| ANL <- data[[dataname]]() # nolint | ||
| validate(need(nlevels(ANL[[input$arm_var]]) > 1, "Arm needs to have at least 2 levels")) |
There was a problem hiding this comment.
nlevels works only with factors, which means:
- if
ANL[[arm_var]]is not a factor the validation message will be printed. - (1) means that variable named
arm_varhave to be a factor. There is not other possibility - This simplifies our problem with
c(input$arm_trt, input$arm_ref) %in% ANL_UNFILTERED[[input$arm_var]])because we can define choices in the line 252 aschoices <- levels(ANL[[arm_var]])
gogonzo
commented
Aug 22, 2022
| @@ -242,14 +242,14 @@ srv_g_ae_oview <- function(id, | |||
| }) | |||
|
|
|||
| observeEvent(input$arm_var, { | |||
| ANL <- datasets$get_data(dataname, filtered = FALSE) # nolint | |||
There was a problem hiding this comment.
to reviewer:
filtered = FALSE was used only to make "arm_ref" selectInput to have all variable choices (including filtered). We assume that variable is a factor - then levels are taken from the factor (
|
Code Coverage SummaryResults for commit: a52e172 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
mhallal1
reviewed
Aug 25, 2022
Co-authored-by: Mahmoud Hallal <[email protected]>
Polkas
reviewed
Aug 26, 2022
| pre_output = a$pre_output, | ||
| post_output = a$post_output | ||
| ) | ||
| } | ||
|
|
||
| srv_g_waterfall <- function(id, | ||
| datasets, | ||
| data, |
There was a problem hiding this comment.
In the roxygen example set the following 3 options and you get this:
There was a problem hiding this comment.
same on main - i made an issue
mhallal1
reviewed
Sep 7, 2022
mhallal1
reviewed
Sep 7, 2022
Fix docs grammar Co-authored-by: Mahmoud Hallal <[email protected]> Co-authored-by: Nikolas Burkoff <[email protected]>
mhallal1
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #145 #141